Page MenuHomeFreeBSD

Sandbox wc(1) with fileargs.
ClosedPublic

Authored by oshogbo on Feb 17 2018, 12:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 24, 5:57 AM
Unknown Object (File)
May 10 2024, 2:06 PM
Unknown Object (File)
May 3 2024, 9:16 PM
Unknown Object (File)
May 2 2024, 5:51 PM
Unknown Object (File)
May 2 2024, 5:51 PM
Unknown Object (File)
May 2 2024, 2:27 PM
Unknown Object (File)
May 2 2024, 2:24 PM
Unknown Object (File)
Apr 27 2024, 1:43 PM
Subscribers

Details

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This looks pretty clean, I like it.

usr.bin/wc/wc.c
144

Doesn't this need to be before the first use of err.h? It should be before the above if() because of the xo_warn()

This revision is now accepted and ready to land.Feb 17 2018, 5:12 PM
usr.bin/wc/wc.c
144

But this is needed only when we are in capability mode which we enter below, so if xo_warn will be called it will still have access to the NLS.

We handle now empty argc and argv.

This revision now requires review to proceed.Feb 21 2018, 9:57 PM

Looks good

usr.bin/wc/wc.c
49

should sort alphabetically before stat

This revision is now accepted and ready to land.Feb 22 2018, 12:46 AM