Details

Reviewers

None

Group Reviewers

docs

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 71094
Build 67977: arc lint + arc unit

Event Timeline

aokblast created this revision.Feb 28 2026, 2:24 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 28 2026, 2:24 PM

aokblast requested review of this revision.Feb 28 2026, 2:24 PM

Harbormaster completed remote builds in B71093: Diff 172929.Feb 28 2026, 2:24 PM

Fix sysctl

Harbormaster completed remote builds in B71094: Diff 172930.Feb 28 2026, 2:31 PM

Needs a SPDX tag and copyright statement

With this patch, on a framework 16 (AI 300) I see

# sysctl dev.fan.0
dev.fan.0.fine_grind: 0
dev.fan.0.status: Control Level: 100, Speed: 1674 RPM
dev.fan.0.levels:
dev.fan.0.%domain: -1
dev.fan.0.%iommu:
dev.fan.0.%parent: acpi0
dev.fan.0.%pnpinfo: _HID=PNP0C0B _UID=0 _CID=none
dev.fan.0.%location: handle=\_SB_.FAN_
dev.fan.0.%driver: fan
dev.fan.0.%desc:

Fixup for sysctl node

Harbormaster completed remote builds in B71982: Diff 174956.Apr 6 2026, 12:52 PM

Fix FPS parse

Harbormaster completed remote builds in B71983: Diff 174957.Apr 6 2026, 1:05 PM

Just received panic: mtx_lock() of spin mutex Fan mutex @ ... upon sysctl -a.
I may not have all updates from this review in place.

Add missing mtx_unlock

Harbormaster completed remote builds in B72943: Diff 177481.May 9 2026, 8:28 AM

In D55592#1303241, @emaste wrote:

Just received panic: mtx_lock() of spin mutex Fan mutex @ ... upon sysctl -a.
I may not have all updates from this review in place.

Thanks! Should be fixed now.