Page MenuHomeFreeBSD
Differential D55576

Only build USB-related modules if MK_USB != no
ClosedPublic
Actions

Authored by ngie on Feb 27 2026, 9:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 27, 11:43 AM
Unknown Object (File)
Mon, Jul 27, 11:04 AM
Unknown Object (File)
Mon, Jul 27, 8:49 AM
Unknown Object (File)
Thu, Jul 23, 5:25 PM
Unknown Object (File)
Thu, Jul 23, 9:33 AM
Unknown Object (File)
Thu, Jul 23, 1:30 AM
Unknown Object (File)
Tue, Jul 21, 6:50 PM
Unknown Object (File)
Mon, Jul 20, 12:21 AM
View All 64 Files
Subscribers
bdrewery
bz
dab
vangyzen
USB

Details

Reviewers
imp
Commits
rG253d17af2e6a: Only build USB-related modules if MK_USB != no
rGc47cefba8312: Only build USB-related modules if MK_USB != no
Summary

This change moves the thunderbolt module and other USB modules under a
MK_USB != no conditional to ensure that users not desiring USB support
can build systems without USB-specific drivers.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71086
Build 67969: arc lint + arc unit

Event Timeline

ngie created this revision.Feb 27 2026, 9:02 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 27 2026, 9:02 PM
ngie requested review of this revision.Feb 27 2026, 9:02 PM
Harbormaster completed remote builds in B71083: Diff 172895.Feb 27 2026, 9:02 PM
ngie added inline comments.Feb 27 2026, 9:04 PM
sys/modules/Makefile
949–954

This went missing when resolving a merge conflict on my branch after shuffling the stack around. This wasn't intentional.

ngie added a reviewer: imp.Feb 27 2026, 9:04 PM
ngie removed a subscriber: imp.
ngie added subscribers: dab, vangyzen, bdrewery, USB.
imp accepted this revision.Feb 27 2026, 9:07 PM

So there's two competing mechanism now for usb: the kernel config file (which better not be setting this) and the user WITH/WITHOUT mechanism. This is a bit weird and novel for the kernel and may or may not be easy to support in configng.

This revision is now accepted and ready to land.Feb 27 2026, 9:07 PM
bz added a subscriber: bz.Feb 27 2026, 9:21 PM

Sorry but where are _rtwn_usb and _usb defined now?

ngie updated this revision to Diff 172899.Feb 27 2026, 10:47 PM
  • Re-add drivers that got accidentally removed in the earlier diff.
  • Put ufshci back: I mistakingly though the driver was related to USB, but it's not.
This revision now requires review to proceed.Feb 27 2026, 10:47 PM
Harbormaster completed remote builds in B71086: Diff 172899.Feb 27 2026, 10:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 3 2026, 4:51 AM
Closed by commit rGc47cefba8312: Only build USB-related modules if MK_USB != no (authored by ngie). · Explain Why
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rGc47cefba8312: Only build USB-related modules if MK_USB != no.
ngie added a commit: rG253d17af2e6a: Only build USB-related modules if MK_USB != no.Apr 25 2026, 4:23 PM

Revision Contents
Changeset List

PathSize
sys/
conf/
5 lines
8 lines
modules/
16 lines

Diff 172899

View Options

sys/conf/kern.opts.mk

Loading...
View Options

sys/conf/kmod.mk

Loading...
View Options

sys/modules/Makefile

Loading...