Paths

Table of Contentst

Differential D46709

VFS: add flags arg to VOP_STAT() and VOP_GETATTR()
AbandonedPublic
Actions

Authored by kib on Sep 20 2024, 6:28 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 17, 10:42 AM

	Unknown Object (File)
	Sun, May 17, 7:51 AM

	Unknown Object (File)
	Thu, May 14, 3:52 AM

	Unknown Object (File)
	Wed, May 13, 10:20 PM

	Unknown Object (File)
	Wed, May 13, 10:12 PM

	Unknown Object (File)
	Mar 19 2026, 12:09 PM

	Unknown Object (File)
	Mar 2 2026, 2:57 PM

	Unknown Object (File)
	Feb 27 2026, 6:45 PM

View All 77 Files

Subscribers

Details

Reviewers

emaste
markj
olce

Group Reviewers

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Sep 20 2024, 6:28 AM

Herald added a reviewer: olce. · View Herald TranscriptSep 20 2024, 6:28 AM

Herald added a reviewer: cam. · View Herald Transcript

Herald added subscribers: linuxkpi, olce, glebius and 2 others. · View Herald Transcript

kib requested review of this revision.Sep 20 2024, 6:28 AM

kib added a child revision: D46710: autofs: add NOAUTOMOUNT flag for lookups initiated by stat(2) and family.Sep 20 2024, 6:34 AM

Also add flags to VOP_ATTRIB.9

In D46709#1065003, @emaste wrote:

Also add flags to VOP_ATTRIB.9

Done is separate commit.

/home/emaste/src/freebsd-git/wipbsd/sys/security/audit/audit_arg.c:874:53: error: too few arguments to function call, expected 4, have 3
  874 |         error = VOP_GETATTR(vp, &vattr, curthread->td_ucred);
      |                 ~~~~~~~~~~~                                ^

In D46709#1065095, @emaste wrote:

/home/emaste/src/freebsd-git/wipbsd/sys/security/audit/audit_arg.c:874:53: error: too few arguments to function call, expected 4, have 3
  874 |         error = VOP_GETATTR(vp, &vattr, curthread->td_ucred);
      |                 ~~~~~~~~~~~                                ^

Fixed, the whole patch series is available at https://kib.kiev.ua/git/gitweb.cgi?p=deviant3.git;a=shortlog;h=refs/heads/noautomount

Also sys/dev/xen/blkback/blkback.c. My wip build was successful patching audit and xen; I didn't look for other VOP_GETATTR cases.

olce accepted this revision.Sep 20 2024, 12:54 PM

This revision is now accepted and ready to land.Sep 20 2024, 12:54 PM

emaste accepted this revision.Sep 20 2024, 1:01 PM

kib abandoned this revision.Sep 21 2024, 9:17 PM

This requires a __FreeBSD_version bump, of course, to accommodate out-of-tree zfs.ko.

Revision Contents
Changeset List

Path

Size

sys/

cam/

ctl/

ctl_backend_block.c

4 lines

compat/

linprocfs/

2 lines

linux/

2 lines

linuxkpi/

common/

src/

2 lines

contrib/

openzfs/

module/

os/

freebsd/

zfs/

2 lines

2 lines

dev/

md/

2 lines

fs/

autofs/

2 lines

nfsclient/

6 lines

26 lines

nfsserver/

14 lines

2 lines

nfs_nfsdstate.c

6 lines

p9fs/

6 lines

pseudofs/

pseudofs_vnops.c

2 lines

smbfs/

6 lines

4 lines

16 lines

tarfs/

2 lines

4 lines

tmpfs/

2 lines

unionfs/

10 lines

2 lines

10 lines

kern/

2 lines

2 lines

4 lines

2 lines

4 lines

kern_sendfile.c

2 lines

4 lines

subr_firmware.c

2 lines

2 lines

2 lines

16 lines

2 lines

4 lines

12 lines

8 lines

2 lines

security/

mac_bsdextended/

mac_bsdextended.c

2 lines

mac_lomac/

2 lines

sys/

4 lines

ufs/

ffs/

2 lines

vm/

2 lines

2 lines

2 lines

Diff 143505

sys/cam/ctl/ctl_backend_block.c

Loading...

sys/compat/linprocfs/linprocfs.c

Loading...

sys/compat/linux/linux_stats.c

Loading...

sys/compat/linuxkpi/common/src/linux_compat.c

Loading...

sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c

Loading...

sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c

Loading...

sys/dev/md/md.c

Loading...

sys/fs/autofs/autofs_vnops.c

Loading...

sys/fs/nfsclient/nfs_clbio.c

Loading...

sys/fs/nfsclient/nfs_clvnops.c

Loading...

sys/fs/nfsserver/nfs_nfsdport.c

Loading...

sys/fs/nfsserver/nfs_nfsdserv.c

Loading...

sys/fs/nfsserver/nfs_nfsdstate.c

Loading...

sys/fs/p9fs/p9fs_vnops.c

Loading...

sys/fs/pseudofs/pseudofs_vnops.c

Loading...

sys/fs/smbfs/smbfs_io.c

Loading...

sys/fs/smbfs/smbfs_node.c

Loading...

sys/fs/smbfs/smbfs_vnops.c

Loading...

sys/fs/tarfs/tarfs_io.c

Loading...

sys/fs/tarfs/tarfs_vfsops.c

Loading...

sys/fs/tmpfs/tmpfs_vfsops.c

Loading...

sys/fs/unionfs/union_subr.c

Loading...

sys/fs/unionfs/union_vfsops.c

Loading...

sys/fs/unionfs/union_vnops.c

Loading...

sys/kern/imgact_shell.c

Loading...

sys/kern/kern_exec.c

Loading...

sys/kern/kern_linker.c

Loading...

sys/kern/kern_lockf.c

Loading...

sys/kern/kern_proc.c

Loading...

sys/kern/kern_sendfile.c

Loading...

sys/kern/kern_sig.c

Loading...

sys/kern/subr_firmware.c

Loading...

sys/kern/sys_process.c

Loading...

sys/kern/uipc_mqueue.c

Loading...

sys/kern/vfs_default.c

Loading...

sys/kern/vfs_mount.c

Loading...

sys/kern/vfs_subr.c

Loading...

sys/kern/vfs_syscalls.c

Loading...

sys/kern/vfs_vnops.c

Loading...

sys/kern/vnode_if.src

Loading...

sys/security/mac_bsdextended/mac_bsdextended.c

Loading...

sys/security/mac_lomac/mac_lomac.c

Loading...

sys/sys/vnode.h

Loading...

sys/ufs/ffs/ffs_snapshot.c

Loading...

sys/vm/swap_pager.c

Loading...

sys/vm/vm_mmap.c

Loading...

sys/vm/vm_object.c

Loading...