This is largely a simplification, avoiding extra allocations or string
manipulations where it's safe to do so (i.e., doesn't require extra
quoting).
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 44719 Build 41607: arc lint + arc unit
Event Timeline
Comment Actions
I just noticed there's a devctl_notify(9) to update.
| sys/dev/asmc/asmc.c | ||
|---|---|---|
| 1358 | I assumed the space here is insignificant and just gets absorbed as consecutive whitespace... | |
Comment Actions
I wish we had a way to validate that things were safe, though...
Maybe I'll add it after you commit this.
| sys/dev/asmc/asmc.c | ||
|---|---|---|
| 1358 | correct. | |
Comment Actions
Rebase and hit a few more devctl_notify() callers
vtterm_devctl(), in particular, becomes significantly less complicated as the
complexity of the operation moves into devctl_notifyf (where it would need to
allocate another sbuf, etc., even before devctl_notifyf was introduced).