lib.
ClosedPublic
Actions

Authored by jhb on Jan 11 2022, 7:22 PM.

Details

Reviewers

emaste
imp

Commits

rG454aedb165f3: Use MOVED_LIBS for libraries moved between /usr/lib and /lib.
rG57ba3f00f5e9: Use MOVED_LIBS for libraries moved between /usr/lib and /lib.

Summary

Add a MOVED_LIBS variable similar to OLD_LIBS except that MOVED_LIBS
is used for the cases that a library's name doesn't change, but it
just moves between /usr/lib and /lib. This will be used by a future
change to auto-generate lib32 old files entries for which these cases
need to be ignored (a moved library remains in /usr/lib32).

Suggested by: emaste

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43860
Build 40748: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 11 2022, 7:22 PM

Herald added a subscriber: jonathan. · View Herald TranscriptJan 11 2022, 7:22 PM

jhb requested review of this revision.Jan 11 2022, 7:22 PM

Harbormaster completed remote builds in B43860: Diff 101315.Jan 11 2022, 7:22 PM

jhb added a parent revision: D33847: Rework documentation of OLD_*..Jan 11 2022, 7:22 PM

jhb added a child revision: D33849: Use MOVED_LIBS for the libalias modules being moved to /lib..

LGTM with one comment you can consider. I didn't check for any missed entries that should become MOVED_LIBS.

ObsoleteFiles.inc
7	Perhaps we should add a brief explanation why, or a link to the handbook? Users leaving old libraries around for existing binaries is obvious to anyone who has dealt with this for some time but may not be apparent to someone new adding an entry. I thought of this only because D33849 is an exception to this statement. Perhaps something like "In this way users may avoid deleting old dynamic libraries still required by existing binaries." or so.

This revision is now accepted and ready to land.Jan 14 2022, 3:20 PM

Note that I compared the before/after of list-old-files and list-old-libs before this change and after the lib32 change to find the places that needed to use MOVED_LIBS.