Page MenuHomeFreeBSD
Differential D33847

Rework documentation of OLD_*.
ClosedPublic
Actions

Authored by jhb on Jan 11 2022, 7:21 PM.
Tags
None
Referenced Files
F166545994: D33847.diff
Fri, Aug 14, 7:03 AM
Unknown Object (File)
Mon, Aug 3, 9:52 PM
Unknown Object (File)
Sun, Aug 2, 5:36 AM
Unknown Object (File)
Sat, Aug 1, 6:41 AM
Unknown Object (File)
Sat, Jul 25, 2:40 PM
Unknown Object (File)
Thu, Jul 23, 7:03 AM
Unknown Object (File)
Wed, Jul 22, 1:23 PM
Unknown Object (File)
Mon, Jul 20, 2:32 PM
View All Files
Subscribers
None

Details

Reviewers
emaste
imp
Commits
rG7344bc6cb7b4: Rework documentation of OLD_*.
rGc96dfb2156fa: Rework documentation of OLD_*.
Summary
  • Be more explicit in the difference between OLD_DIRS and OLD_FILES (the former is only in delete-old-libs whereas the latter is in delete-old).
  • Document that debug symbols in /usr/lib/debug/ for files in OLD_FILES and OLD_LIBS are removed as well.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43970
Build 40858: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Jan 11 2022, 7:21 PM
jhb created this revision.
Harbormaster completed remote builds in B43859: Diff 101314.Jan 11 2022, 7:21 PM
jhb added a child revision: D33848: Use MOVED_LIBS for libraries moved between /usr/lib and /lib..Jan 11 2022, 7:22 PM
emaste added inline comments.Jan 11 2022, 7:54 PM
ObsoleteFiles.inc
10

This seems to imply that delete-old excludes OLD_LIBS?

jhb added inline comments.Jan 11 2022, 8:24 PM
ObsoleteFiles.inc
10

That's because it does exclude OLD_LIBS. check-old lists all of them but delete-old excludes OLD_LIBS on purpose (that's the entire point of OLD_LIBS AFAICT).

emaste accepted this revision.Jan 14 2022, 2:21 AM
This revision is now accepted and ready to land.Jan 14 2022, 2:21 AM
jhb updated this revision to Diff 101592.Jan 18 2022, 6:54 PM

Add a note explaining why we separate delete-old-libs from delete-old.

This revision now requires review to proceed.Jan 18 2022, 6:54 PM
Harbormaster completed remote builds in B43970: Diff 101592.Jan 18 2022, 6:54 PM
emaste accepted this revision.Jan 18 2022, 7:55 PM
This revision is now accepted and ready to land.Jan 18 2022, 7:55 PM
jhb closed this revision.Jan 20 2022, 10:09 PM
jhb added a commit: rGc96dfb2156fa: Rework documentation of OLD_*..
jhb added a commit: rG7344bc6cb7b4: Rework documentation of OLD_*..Jul 29 2022, 7:49 PM

Revision Contents
Changeset List

PathSize
19 lines
tools/
build/
mk/
4 lines

Diff 101592

View Options

ObsoleteFiles.inc

Loading...
View Options

tools/build/mk/OptionalObsoleteFiles.inc

Loading...