Page MenuHomeFreeBSD

Use MOVED_LIBS for libraries moved between /usr/lib and /lib.
ClosedPublic

Authored by jhb on Jan 11 2022, 7:22 PM.
Tags
None
Referenced Files
F103248235: D33848.id.diff
Fri, Nov 22, 3:03 PM
F103242795: D33848.id101315.diff
Fri, Nov 22, 1:47 PM
F103222797: D33848.id101702.diff
Fri, Nov 22, 9:30 AM
F103213109: D33848.id101593.diff
Fri, Nov 22, 7:21 AM
Unknown Object (File)
Mon, Nov 18, 6:28 PM
Unknown Object (File)
Mon, Nov 18, 11:49 AM
Unknown Object (File)
Sun, Nov 17, 10:04 PM
Unknown Object (File)
Sun, Nov 17, 4:10 PM
Subscribers

Details

Summary

Add a MOVED_LIBS variable similar to OLD_LIBS except that MOVED_LIBS
is used for the cases that a library's name doesn't change, but it
just moves between /usr/lib and /lib. This will be used by a future
change to auto-generate lib32 old files entries for which these cases
need to be ignored (a moved library remains in /usr/lib32).

Suggested by: emaste

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43971
Build 40859: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Jan 11 2022, 7:22 PM

LGTM with one comment you can consider. I didn't check for any missed entries that should become MOVED_LIBS.

ObsoleteFiles.inc
6–12

Perhaps we should add a brief explanation why, or a link to the handbook? Users leaving old libraries around for existing binaries is obvious to anyone who has dealt with this for some time but may not be apparent to someone new adding an entry.

I thought of this only because D33849 is an exception to this statement.

Perhaps something like "In this way users may avoid deleting old dynamic libraries still required by existing binaries." or so.

This revision is now accepted and ready to land.Jan 14 2022, 3:20 PM

Note that I compared the before/after of list-old-files and list-old-libs before this change and after the lib32 change to find the places that needed to use MOVED_LIBS.

ObsoleteFiles.inc
6–12

Ok, but I should probably add this to the earlier commit rewriting the description here.

This revision now requires review to proceed.Jan 18 2022, 6:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 20 2022, 8:50 PM
This revision was automatically updated to reflect the committed changes.