There is an updated review at https://reviews.freebsd.org/D56898, based on Antranig's patch.

Improve route acquisition message when both default routes are added simultaneously; clarify AF checking comment; remove empty line.

Cache and reduce address-family support check as suggested.

functionally LGTM and it will fix our compliance with RFC8925.
I'm not an rc expert. So I can't comment on its code.
But it works perfectly with D56637.

The patch allows interface renaming (by rc.conf(5)) for epair (cloned) interfaces and also for devd(8) configured interfaces.
'ifconfing description' is changed to be always applied (if defined), whether or not the NOAUTO keywork was found.
It also fixes non-functional NOAUTO config keyword for targeted start_interface commands (by devd(8)).
And in addition makes NOAUTO the default for devd(8) configured interfaces if rc.conf(5) lacks a corresponding interface configuration.

Rebasing the files from 2 years ago might be too much to do, so I am abandoning this revision, and I shall do a new diff now that service.sh has much more nicer features which will indeed help -s as well.

I am not sure if we should make our services read load more configuration files or perhaps solve this issue with symlinks.

There is a second problem I've discovered... ifconfig_DEFAULT= only works in /etc/rc.conf. It does not work when put into /etc/rc.conf.local or any of these files in /etc/rc.conf.d/

I kinda wonder if load_rc_config $name should be the last one loaded so /etc/rc.conf.d/dhclient overrides the other files...

Not in -current, tagging for srcmgr review.

Hmm, actually, our documentation is slightly contradicting.

• Rebase
• Add tests

Thanks!

In D45855#1160605, @hrs wrote:

https://people.allbsd.org/~hrs/FreeBSD/f1692c.diff

In D45855#1160514, @kenrap_kennethraplee.com wrote:

In D45855#1160497, @hrs wrote:

Could you explain your configuation and behavior change in more detail?

Sure thing. I use the following in my rc.conf which enlarges the virtual terminal fonts from being small after loading a drm-kmod driver during the booting process:

allscreens_flags="-f spleen-16x32"

After doing a src tree build upgrade today this functionality had stopped. By manually removing both set -o noglob and set +o noglob lines, I restored the original functionality.

The problem is that allscreens_flags relies on the pathname expansion in two places:
https://github.com/freebsd/freebsd-src/blob/4deb9760a9d84d5861ee45162ffebe83f13503b8/libexec/rc/rc.d/syscons#L237-L243
https://github.com/freebsd/freebsd-src/blob/4deb9760a9d84d5861ee45162ffebe83f13503b8/libexec/rc/rc.d/syscons#L381-L387

In D45855#1160497, @hrs wrote:

Could you explain your configuation and behavior change in more detail?

Sure thing. I use the following in my rc.conf which enlarges the virtual terminal fonts from being small after loading a drm-kmod driver during the booting process:

allscreens_flags="-f spleen-16x32"

After doing a src tree build upgrade today this functionality had stopped. By manually removing both set -o noglob and set +o noglob lines, I restored the original functionality.

In D45855#1160402, @kenrap_kennethraplee.com wrote:

This change introduced a regression where my allscreens_flags settings gets ignored at boot.

This change introduced a regression where my allscreens_flags settings gets ignored at boot.