(WIP) rc: Allow environment to override sourced rc.conf

[kevans]

Summary

This is the idea I've got in the back of my mind to allow for easier testing of service(8), maybe sysrc(8) if that makes sense as well.

Allow override of local rc.conf with an environment variable, in similar fashion to __MAKE_CONF: __RC_CONF. This allows the environment to override the sourcing of /etc/rc.conf and /etc/rc.conf.local for reasonable testing of service(8). An example test being able to create an rc.conf that overrides local_startup and/or other rc vars so that it can reasonably test without worrying about an installed port breaking things.

[dteske]

I understand the double-underbar prefix as an analog to __MAKE_CONF but right above __RC_CONF is RC_PID; could we make it RC_CONF to be more internally consistent within the given file?

[kevans]

In D13946#296932, @dteske wrote:

I understand the double-underbar prefix as an analog to MAKE_CONF but right above RC_CONF is RC_PID; could we make it RC_CONF to be more internally consistent within the given file?

Sure- I'm not set on any of it, to be honest- I figured the double-underbar prefix would also make it harder to accidentally set, but I suppose RC_CONF is already not something likely to be accidentally set. ;)

Do you have any opinions on this as a mechanism in general? It'd be nice if we could test service(8) and some friends within our normal test framework without imposing jails as a requirement, but I can see where one might prefer such tests to be jail-based. The problem is that I *think* jail-based tests, though eventually necessary, are going to be pretty heavy from a testing perspective.

[dteske]

etc/defaults/rc.conf

20–21

Don’t default-assign -- with the test below this always fires and rc_conf_files becomes /etc/rc.conf every boot (drops .local).

Suggest deleting this line and consuming RC_CONF only in source_rc_confs when set.

706–708

Override only when set (empty = no local files)

etc/rc.subr

36

Makes set-NULL invalid where NULL is a valid choice (means no default files)

Suggest deleting this line

1377–1379

-r and . want one path; RC_CONF is a list. Unquoted. If unset, still want /etc/rc.conf