Page MenuHomeFreeBSD

defaultroute: fix dual-stack and IPv6-only handling
AcceptedPublic

Authored by zarychtam_plan-b.pwste.edu.pl on Mon, May 4, 8:07 PM.
Referenced Files
Unknown Object (File)
Wed, May 20, 12:18 PM
Unknown Object (File)
Wed, May 20, 12:07 PM
Unknown Object (File)
Mon, May 18, 4:39 AM
Unknown Object (File)
Mon, May 18, 12:36 AM
Unknown Object (File)
Sat, May 16, 7:36 PM
Unknown Object (File)
Sat, May 16, 10:57 AM
Unknown Object (File)
Sat, May 16, 9:35 AM
Unknown Object (File)
Sat, May 16, 8:44 AM
Subscribers

Details

Summary

Since IPv6-only setups are becoming more common, and IPv6 connectivity is often sufficient for tasks such as DNS resolution and NTP time synchronization, we should consider updating this rc.d script.

I have been testing D56637 recently, and if this change is accepted and lands, it will also require an update to the defaultroute script. However, regardless of the status of D56637, the defaultroute script can be made network stack–independent and support both inet and inet6.

If the kernel supports neither INET nor INET6 (which is theoretically possible), the script will return immediately, as it did previously when INET support was absent.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

functionally LGTM and it will fix our compliance with RFC8925.
I'm not an rc expert. So I can't comment on its code.
But it works perfectly with D56637.

This revision is now accepted and ready to land.Tue, May 5, 4:33 PM

Cache and reduce address-family support check as suggested.

This revision now requires review to proceed.Tue, May 5, 5:34 PM
This revision is now accepted and ready to land.Tue, May 5, 8:56 PM

Improve route acquisition message when both default routes are added simultaneously; clarify AF checking comment; remove empty line.

Thanks for testing and feedback, including direct outreach.

While working on this change, I noticed that devd(8) requires INET to function; report and fix submitted (PR 295045).

This revision now requires review to proceed.Wed, May 6, 12:37 PM
This revision is now accepted and ready to land.Wed, May 6, 8:16 PM