Page MenuHomeFreeBSD
Differential D57664

CHERI: declare fueptr and suptr
ClosedPublic
Actions

Authored by brooks on Fri, Jun 19, 2:12 PM.
Tags
None
Referenced Files
F162712361: D57664.id180519.diff
Thu, Jul 16, 1:43 AM
Unknown Object (File)
Wed, Jul 15, 7:26 AM
Unknown Object (File)
Wed, Jul 15, 7:26 AM
Unknown Object (File)
Mon, Jul 13, 1:10 PM
Unknown Object (File)
Wed, Jul 8, 7:16 AM
Unknown Object (File)
Mon, Jul 6, 5:03 AM
Unknown Object (File)
Sun, Jul 5, 8:42 AM
Unknown Object (File)
Sun, Jul 5, 6:42 AM
View All 29 Files
Subscribers
imp
ziaee

Details

Reviewers
kib
markj
jhb
jrtc27
Group Reviewers
cheri
Commits
rGa1c52e05f571: CHERI: declare fueptr and suptr
Summary

These should replace fueword and suword when manipulating pointers in
memory. On CHERI systems they are implemented using capability aware
instructions and otherwise they are defined to fueword and suword.

Effort: CHERI upstreaming
Sponsored by: Innovate UK

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74239
Build 71122: arc lint + arc unit

Event Timeline

brooks created this revision.Fri, Jun 19, 2:12 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Jun 19, 2:12 PM
brooks requested review of this revision.Fri, Jun 19, 2:12 PM
Harbormaster completed remote builds in B73999: Diff 180059.Fri, Jun 19, 2:12 PM
Herald added a reviewer: cheri. · View Herald TranscriptFri, Jun 19, 2:12 PM
Herald added a reviewer: cheri. · View Herald Transcript
brooks added a parent revision: D57663: CHERI: declare copy{in,out}ptr{,_nofault}.Fri, Jun 19, 2:13 PM
brooks added a child revision: D57665: CHERI: add sooptcopyinptr to preserve pointer provenance.
brooks updated this revision to Diff 180519.Wed, Jun 24, 10:08 AM

Document and link manpages to the description of pointer provenacne in arch(7)

Herald added a subscriber: ziaee. · View Herald TranscriptWed, Jun 24, 10:08 AM
Harbormaster completed remote builds in B74196: Diff 180519.Wed, Jun 24, 10:08 AM
markj accepted this revision as: markj.Wed, Jun 24, 2:38 PM
markj added inline comments.
share/man/man9/fetch.9
107
share/man/man9/store.9
41
sys/sys/systm.h
373

We should really settle on __nodiscard vs. __result_use_check.

This revision is now accepted and ready to land.Wed, Jun 24, 2:38 PM
brooks updated this revision to Diff 180611.Thu, Jun 25, 10:41 AM
brooks marked 2 inline comments as done.

Fix some manpage nits

This revision now requires review to proceed.Thu, Jun 25, 10:41 AM
Harbormaster completed remote builds in B74239: Diff 180611.Thu, Jun 25, 10:41 AM
brooks updated this revision to Diff 180704.Fri, Jun 26, 12:17 PM

Use __nodiscard

Harbormaster completed remote builds in B74294: Diff 180704.Fri, Jun 26, 12:18 PM
brooks added a parent revision: D57882: sys/systm.h: use __nodiscard consistently and correctly.Fri, Jun 26, 12:18 PM
brooks marked an inline comment as done.
kib accepted this revision.Fri, Jun 26, 6:18 PM
This revision is now accepted and ready to land.Fri, Jun 26, 6:18 PM
Closed by commit rGa1c52e05f571: CHERI: declare fueptr and suptr (authored by brooks). · Explain WhyMon, Jun 29, 1:02 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGa1c52e05f571: CHERI: declare fueptr and suptr.

Revision Contents
Changeset List

PathSize
share/
man/
man9/
2 lines
14 lines
10 lines
sys/
sys/
10 lines

Diff 180611

View Options

share/man/man9/Makefile

Loading...
View Options

share/man/man9/fetch.9

Loading...
View Options

share/man/man9/store.9

Loading...
View Options

sys/sys/systm.h

Loading...