Differential D57665

CHERI: add sooptcopyinptr to preserve pointer provenance
ClosedPublic
Actions

Authored by brooks on Fri, Jun 19, 2:13 PM.

Tags

None

Referenced Files

	F162638422: D57665.diff
	Wed, Jul 15, 7:26 AM

	F162638421: D57665.diff
	Wed, Jul 15, 7:26 AM

	Unknown Object (File)
	Mon, Jul 6, 4:24 PM

	Unknown Object (File)
	Sun, Jul 5, 5:12 AM

	Unknown Object (File)
	Sat, Jul 4, 9:44 AM

	Unknown Object (File)
	Sat, Jul 4, 6:01 AM

	Unknown Object (File)
	Fri, Jul 3, 3:36 AM

	Unknown Object (File)
	Thu, Jul 2, 8:32 PM

View All 23 Files

Subscribers

Details

Reviewers

kib
markj
jhb
jrtc27
emaste

Group Reviewers

Commits

rGf14bdfefa41c: CHERI: add sooptcopyinptr to preserve pointer provenance

Summary

Most socket options don't involve pointers so make the default
sooptcopyin discard provenance and add a sooptcopyinptr that preserves.

Effort: CHERI upstreaming
Sponsored by: DARPA, AFRL, Innovate UK

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Fri, Jun 19, 2:13 PM

Herald added subscribers: ziaee, olce, glebius, imp. · View Herald TranscriptFri, Jun 19, 2:13 PM

brooks requested review of this revision.Fri, Jun 19, 2:13 PM

Herald added a reviewer: cheri. · View Herald TranscriptFri, Jun 19, 2:13 PM

brooks added a parent revision: D57664: CHERI: declare fueptr and suptr.Fri, Jun 19, 2:13 PM

Harbormaster completed remote builds in B74000: Diff 180060.Fri, Jun 19, 2:13 PM

use memcpy_data

Harbormaster completed remote builds in B74066: Diff 180177.Sat, Jun 20, 5:12 PM

Link manpages to the description of pointer provenance in arch(7)

Harbormaster completed remote builds in B74197: Diff 180520.Wed, Jun 24, 10:09 AM

markj accepted this revision as: markj.Wed, Jun 24, 1:41 PM

This revision is now accepted and ready to land.Wed, Jun 24, 1:41 PM

emaste added a subscriber: emaste.Wed, Jun 24, 1:45 PM

emaste added inline comments.

share/man/man9/socket.9
589	Should we strengthen this somewhat, e.g. "no consumers exist or are anticipated"? Is it "we didn't do this because nobody needs it now" or "we don't think this really makes sense". Given that we generally pass in buffers for the kernel to populate the latter is probably the case?

Be clear that sooptcopyoutptr is missing because it makes no sense

This revision now requires review to proceed.Thu, Jun 25, 10:48 AM

Harbormaster completed remote builds in B74240: Diff 180612.Thu, Jun 25, 10:48 AM

brooks marked an inline comment as done.Thu, Jun 25, 10:48 AM

emaste accepted this revision as: emaste.Thu, Jun 25, 2:35 PM

This revision is now accepted and ready to land.Thu, Jun 25, 2:35 PM

markj accepted this revision as: markj.Tue, Jun 30, 7:13 PM

markj added inline comments.

share/man/man9/socket.9
590	It's not inconceivable that we'd need this, but ok.

Closed by commit rGf14bdfefa41c: CHERI: add sooptcopyinptr to preserve pointer provenance (authored by brooks). · Explain WhyWed, Jul 1, 11:49 AM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGf14bdfefa41c: CHERI: add sooptcopyinptr to preserve pointer provenance.

Revision Contents
Changeset List

Path

Size

share/

man/

man9/

13 lines

sys/

kern/

34 lines

sys/

6 lines

Diff 181172

share/man/man9/socket.9

Loading...

sys/kern/uipc_socket.c

Loading...

sys/sys/sockopt.h

Loading...