Page MenuHomeFreeBSD

Add kernel manpages for bcopy, memcpy, and memmove
Needs ReviewPublic

Authored by brooks on Fri, Jun 19, 2:12 PM.
Tags
None
Referenced Files
F160276101: D57661.diff
Mon, Jun 22, 8:21 PM
F160276086: D57661.diff
Mon, Jun 22, 8:21 PM
Unknown Object (File)
Sat, Jun 20, 11:25 AM
Unknown Object (File)
Sat, Jun 20, 3:16 AM
Subscribers

Details

Reviewers
kib
markj
jhb
jrtc27
imp
Group Reviewers
cheri
Summary

We will add variants of these to support CHERI so bootstrap the manpages
from section 3.

Effort: CHERI upstreaming
Sponsored by: Innovate UK

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74079
Build 70962: arc lint + arc unit

Event Timeline

This looks fine, other than the 'string' choice. But maybe that's always been there. Maybe it's the standard jargon, but I thought I'd flag it.

share/man/man9/bcopy.9
47

"string" here and below? Is that something that you added for cheri, or is that legacy language. And if it's old, is there a better term?

This revision is now accepted and ready to land.Fri, Jun 19, 6:35 PM
share/man/man9/bcopy.9
47

This is a copy the text in bcopy.3 Glancing at memcpy in POSIX they use "object" instead of string and that would be better.

emaste added inline comments.
share/man/man9/bcopy.9
47

It comes from bcopy(3). I recall a similar discussion when I was working on documenting memcpy & overlapping objects (although I can't find it now).

We could echo "byte string" (from .Nd) or maybe "object"

share/man/man9/bcopy.9
47

We could update the text in the section 3 pages as well

Remove references to strings

This revision now requires review to proceed.Fri, Jun 19, 7:26 PM

Created D57680 to follow POSIX/C's lead and stop talking about strings in mem* functions.

This revision is now accepted and ready to land.Sat, Jun 20, 11:07 AM
This revision now requires review to proceed.Sun, Jun 21, 5:26 PM