Page MenuHomeFreeBSD
Differential D44726

nvmft: The in-kernel NVMe over Fabrics controller
ClosedPublic
Actions

Authored by jhb on Apr 9 2024, 11:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 12:25 PM
Unknown Object (File)
Mon, Sep 7, 12:25 PM
Unknown Object (File)
Mon, Sep 7, 12:25 PM
Unknown Object (File)
Mon, Sep 7, 12:25 PM
Unknown Object (File)
Sun, Sep 6, 3:47 PM
Unknown Object (File)
Sun, Sep 6, 2:10 PM
Unknown Object (File)
Sun, Sep 6, 12:43 PM
Unknown Object (File)
Sun, Sep 6, 7:56 AM
View All Files
Subscribers
None

Details

Reviewers
imp
ken
Commits
rGa15f7c96a276: nvmft: The in-kernel NVMe over Fabrics controller
Summary

This is the server (target in SCSI terms) for NVMe over Fabrics.
Userland is responsible for accepting a new queue pair and receiving
the initial Connect command before handing the queue pair off via an
ioctl to this CTL frontend.

This frontend exposes CTL LUNs as NVMe namespaces to remote hosts.
Users can ask LUNS to CTL that can be shared via either iSCSI or
NVMeoF.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57017
Build 53905: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Apr 9 2024, 11:04 PM
jhb created this revision.
Harbormaster completed remote builds in B57017: Diff 136822.Apr 9 2024, 11:04 PM
jhb added a parent revision: D44725: mbuf: Add EXT_CTL for mbufs backed by a CTL backend buffer.Apr 9 2024, 11:04 PM
jhb added a child revision: D44727: ctladm: Permit creating nvmf ports.
jhb added a reviewer: ken.Apr 9 2024, 11:13 PM
imp accepted this revision.Apr 13 2024, 8:23 PM

Nothing bad stood out, but the size of this makes it hard to review carefully.

sys/dev/nvmf/controller/ctl_frontend_nvmf.c
128

For NDA the LUN == NSID. Does the mismatch matter in this context?

This revision is now accepted and ready to land.Apr 13 2024, 8:23 PM
jhb added a comment.Apr 16 2024, 7:27 PM

This is indeed a large change, but it's not really feasible to split it up further. :(

sys/dev/nvmf/controller/ctl_frontend_nvmf.c
128

No. CTL LUNs start at 0, but NVMe namespaces start at 1, so I can't reuse CTL LUNs directly.

jhb updated this revision to Diff 137998.May 1 2024, 10:51 PM

Switch to SPDX-only license blocks for C files

This revision now requires review to proceed.May 1 2024, 10:51 PM
Harbormaster completed remote builds in B57532: Diff 137998.May 1 2024, 10:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2024, 12:17 AM
Closed by commit rGa15f7c96a276: nvmft: The in-kernel NVMe over Fabrics controller (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGa15f7c96a276: nvmft: The in-kernel NVMe over Fabrics controller.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
1 line
105 lines
sys/
conf/
2 lines
6 lines
dev/
nvmf/
controller/
1144 lines
1151 lines
382 lines
195 lines
modules/
nvmf/
3 lines
nvmft/
10 lines

Diff 136822

View Options

share/man/man4/Makefile

Loading...
View Options

share/man/man4/nvmft.4

Loading...
View Options

sys/conf/NOTES

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/dev/nvmf/controller/ctl_frontend_nvmf.c

Loading...
View Options

sys/dev/nvmf/controller/nvmft_controller.c

Loading...
View Options

sys/dev/nvmf/controller/nvmft_qpair.c

Loading...
View Options

sys/dev/nvmf/controller/nvmft_var.h

Loading...
View Options

sys/modules/nvmf/Makefile

Loading...
View Options

sys/modules/nvmf/nvmft/Makefile

Loading...