Differential D44718

ctl: Add helper routines for setting NVMe completion status
ClosedPublic
Actions

Authored by jhb on Apr 9 2024, 11:04 PM.

Tags

None

Referenced Files

	F167222215: D44718.id136814.diff
	Thu, Aug 20, 1:59 AM

	F167203176: D44718.id.diff
	Wed, Aug 19, 10:08 PM

	F167189570: D44718.id136814.diff
	Wed, Aug 19, 6:42 PM

	Unknown Object (File)
	Sat, Aug 15, 2:35 AM

	Unknown Object (File)
	Sat, Aug 15, 2:35 AM

	Unknown Object (File)
	Sat, Aug 15, 2:35 AM

	Unknown Object (File)
	Sat, Aug 15, 2:34 AM

	Unknown Object (File)
	Fri, Aug 14, 10:16 PM

Subscribers

None

Details

Reviewers

imp
ken

Group Reviewers

Commits

rG75577946b5a1: ctl: Add helper routines for setting NVMe completion status

Summary

Also includes a few protocol-agnostic wrappers for setting a generic
status (such as success) for a CTL I/O request whether it be SCSI or
NVMe.

Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 9 2024, 11:04 PM

Herald added a reviewer: cam. · View Herald TranscriptApr 9 2024, 11:04 PM

jhb requested review of this revision.Apr 9 2024, 11:04 PM

Harbormaster completed remote builds in B57009: Diff 136814.Apr 9 2024, 11:04 PM

jhb added a parent revision: D44717: ctl: Add structure and related constants for NVMe commands.Apr 9 2024, 11:04 PM

jhb added a child revision: D44719: ctl: Support NVMe requests in debug trace functions.

jhb added a reviewer: ken.Apr 9 2024, 11:08 PM

imp accepted this revision.Apr 13 2024, 8:35 PM

This revision is now accepted and ready to land.Apr 13 2024, 8:35 PM

jhb added inline comments.Apr 16 2024, 7:11 PM

sys/cam/ctl/ctl_error.c
1004	Note one thing here (and in libnvmf) is that I currently don't set DNR for any errors. Arguably some of these errors probably should be setting DNR.

imp added inline comments.Apr 16 2024, 7:28 PM

sys/cam/ctl/ctl_error.c
1004	that would be helpful, though not strictly required: it's a performance enhancement

Closed by commit rG75577946b5a1: ctl: Add helper routines for setting NVMe completion status (authored by jhb). · Explain WhyMay 3 2024, 12:16 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG75577946b5a1: ctl: Add helper routines for setting NVMe completion status.

Revision Contents
Changeset List

Path

Size

sys/

cam/

ctl/

27 lines

219 lines

Diff 138070

sys/cam/ctl/ctl_error.h

Loading...

sys/cam/ctl/ctl_error.c

Loading...