Differential D44842

nvmecontrol: Always build instead of being conditional on WITH_NVME
ClosedPublic
Actions

Authored by jhb on Apr 18 2024, 5:44 PM.

Tags

None

Referenced Files

	F132666745: D44842.id137571.diff
	Sat, Oct 18, 9:44 PM

	Unknown Object (File)
	Fri, Sep 26, 4:31 PM

	Unknown Object (File)
	Sat, Sep 20, 5:27 PM

	Unknown Object (File)
	Sat, Sep 20, 12:57 AM

	Unknown Object (File)
	Fri, Sep 19, 6:42 PM

	Unknown Object (File)
	Fri, Sep 19, 10:59 AM

	Unknown Object (File)
	Fri, Sep 19, 9:27 AM

	Unknown Object (File)
	Sep 15 2025, 9:52 PM

View All 99 Files

Subscribers

None

Details

Reviewers

imp
emaste

Commits

rGa3a8eabcdc9c: nvmecontrol: Always build instead of being conditional on WITH_NVME
rG2d51a9898e26: nvmecontrol: Always build instead of being conditional on WITH_NVME

Summary

This now builds fine on all platforms so always include it similar
to other tools such as camcontrol.

Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 18 2024, 5:44 PM

jhb created this revision.

Harbormaster completed remote builds in B57181: Diff 137320.Apr 18 2024, 5:44 PM

jhb added a parent revision: D44841: camcontrol: Enable WITH_NVME uncoditionally.Apr 18 2024, 5:44 PM

jhb added a child revision: D44843: Remove the MK_NVME build option.

emaste accepted this revision.Apr 18 2024, 6:08 PM

This revision is now accepted and ready to land.Apr 18 2024, 6:08 PM

jhb edited the summary of this revision. (Show Details)Apr 18 2024, 7:00 PM

imp accepted this revision.Apr 19 2024, 2:06 AM

Closed by commit rG2d51a9898e26: nvmecontrol: Always build instead of being conditional on WITH_NVME (authored by jhb). · Explain WhyApr 23 2024, 6:49 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG2d51a9898e26: nvmecontrol: Always build instead of being conditional on WITH_NVME.

jhb added a commit: rGa3a8eabcdc9c: nvmecontrol: Always build instead of being conditional on WITH_NVME.Aug 27 2024, 6:07 PM

Revision Contents
Changeset List

Path

Size

sbin/

2 lines

Diff 137571

sbin/Makefile

Loading...