nvmecontrol: Always build instead of being conditional on WITH_NVME
ClosedPublic
Actions

Authored by jhb on Apr 18 2024, 5:44 PM.

Tags

None

Referenced Files

	F86147877: D44842.id137320.diff
	Sun, Jun 16, 3:42 AM

	Unknown Object (File)
	Thu, Jun 13, 6:28 PM

	Unknown Object (File)
	Tue, Jun 4, 12:18 PM

	Unknown Object (File)
	Mon, May 27, 2:12 AM

	Unknown Object (File)
	Sun, May 26, 10:47 AM

	Unknown Object (File)
	Sun, May 26, 10:38 AM

	Unknown Object (File)
	Fri, May 24, 2:54 PM

	Unknown Object (File)
	May 15 2024, 3:48 AM

View All 17 Files

Subscribers

None

Details

Reviewers

imp
emaste

Commits

rG2d51a9898e26: nvmecontrol: Always build instead of being conditional on WITH_NVME

Summary

This now builds fine on all platforms so always include it similar
to other tools such as camcontrol.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 18 2024, 5:44 PM

jhb created this revision.

Harbormaster completed remote builds in B57181: Diff 137320.Apr 18 2024, 5:44 PM

jhb added a parent revision: D44841: camcontrol: Enable WITH_NVME uncoditionally.Apr 18 2024, 5:44 PM

jhb added a child revision: D44843: Remove the MK_NVME build option.

emaste accepted this revision.Apr 18 2024, 6:08 PM

This revision is now accepted and ready to land.Apr 18 2024, 6:08 PM

jhb edited the summary of this revision. (Show Details)Apr 18 2024, 7:00 PM

imp accepted this revision.Apr 19 2024, 2:06 AM

Closed by commit rG2d51a9898e26: nvmecontrol: Always build instead of being conditional on WITH_NVME (authored by jhb). · Explain WhyApr 23 2024, 6:49 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG2d51a9898e26: nvmecontrol: Always build instead of being conditional on WITH_NVME.

Revision Contents
Changeset List

Path

Size

sbin/

Makefile

2 lines

Diff 137571

View Options

nvmecontrol: Always build instead of being conditional on WITH_NVMEClosedPublicActions