Page MenuHomeFreeBSD
Differential D44708

nvmf_tcp.h: Internal header shared between userspace and kernel
AcceptedPublic
Actions

Authored by jhb on Tue, Apr 9, 11:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 7:42 AM
Unknown Object (File)
Fri, Apr 26, 4:22 PM
Unknown Object (File)
Fri, Apr 26, 4:57 AM
Unknown Object (File)
Thu, Apr 25, 11:33 PM
Unknown Object (File)
Thu, Apr 25, 6:13 PM
Unknown Object (File)
Mon, Apr 22, 11:06 AM
Unknown Object (File)
Sat, Apr 13, 7:55 PM
Subscribers
None

Details

Reviewers
imp
Summary
  • Helper macros for specific SGL types used with the TCP transport
  • An inline function which validates various fields in TCP PDUs

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57131
Build 54019: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Tue, Apr 9, 11:03 PM
jhb created this revision.
Harbormaster completed remote builds in B56999: Diff 136804.Tue, Apr 9, 11:03 PM
jhb added a parent revision: D44707: nvmf: Install nvmf.h and nvmf_proto.h in /usr/include/dev/nvmf.Tue, Apr 9, 11:03 PM
jhb added a child revision: D44709: nvmft: Add NVMeoF controller routines shared between kernel and userland.
imp accepted this revision.Sat, Apr 13, 5:58 PM

generally good, could of nits. see other warnings about nvmf knowledge being weak, so I can only do a cursory review of the code.

sys/dev/nvmf/nvmf_tcp.h
31

guard macro names...

34

I'm surprised we don't define this one in sys/cdefs.h

90

since standard section numbering fluctuates between revisions, maybe it would make sense to have a quick note at the top of this fix documenting what version "Section numbers below are against NVMF standard 1.1" or somesuch.

This revision is now accepted and ready to land.Sat, Apr 13, 5:58 PM
jhb marked an inline comment as done.Tue, Apr 16, 5:57 PM
jhb added inline comments.
sys/dev/nvmf/nvmf_tcp.h
34

We don't for userspace. That's a kernel-only macro.

jhb updated this revision to Diff 137176.Tue, Apr 16, 8:43 PM

Add reference to spec

This revision now requires review to proceed.Tue, Apr 16, 8:43 PM
Harbormaster completed remote builds in B57131: Diff 137176.Tue, Apr 16, 8:43 PM
imp accepted this revision.Tue, Apr 16, 9:00 PM
This revision is now accepted and ready to land.Tue, Apr 16, 9:00 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
nvmf/
297 lines

Diff 137176

View Options

sys/dev/nvmf/nvmf_tcp.h

Loading...