Page MenuHomeFreeBSD

ctl: Avoid an upcast for calling ctl_scsi_path_string
ClosedPublic

Authored by jhb on Apr 9 2024, 11:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 28, 8:34 PM
Unknown Object (File)
Fri, Jun 26, 5:32 PM
Unknown Object (File)
Thu, Jun 25, 6:48 AM
Unknown Object (File)
Mon, Jun 22, 11:25 PM
Unknown Object (File)
Mon, Jun 22, 5:54 PM
Unknown Object (File)
Sun, Jun 21, 7:20 PM
Unknown Object (File)
Mon, Jun 15, 5:30 AM
Unknown Object (File)
May 30 2026, 8:50 AM
Subscribers
None

Details

Summary

Change the first argument of ctl_scsi_path_string to be the embedded
header structure instead of the union. Currently union ctl_io and
struct ctl_scsiio have the same alignment, but this changes on i386 if
a new union member is added that contains a uint64_t member (such as
an embedded struct nvme_command for NVMeoF). In that case, union
ctl_io requires stronger alignment, so the upcast from struct
ctl_scsiio to union ctl_io in ctl_scsi_sense_sbuf raises an increasing
alignment warning on i386.

Avoid the warning by passing struct ctl_io_hdr as the first argument
to ctl_scsi_path_string instead.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 9 2024, 11:04 PM
This revision is now accepted and ready to land.Apr 13 2024, 8:35 PM