Page MenuHomeFreeBSD

ctl: Avoid an upcast for calling ctl_scsi_path_string
ClosedPublic

Authored by jhb on Apr 9 2024, 11:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 9:08 PM
Unknown Object (File)
Wed, Oct 8, 9:08 PM
Unknown Object (File)
Wed, Sep 24, 8:58 AM
Unknown Object (File)
Sun, Sep 21, 12:44 PM
Unknown Object (File)
Wed, Sep 17, 7:31 AM
Unknown Object (File)
Sep 11 2025, 7:17 AM
Unknown Object (File)
Sep 10 2025, 10:41 AM
Unknown Object (File)
Sep 4 2025, 12:41 AM
Subscribers
None

Details

Summary

Change the first argument of ctl_scsi_path_string to be the embedded
header structure instead of the union. Currently union ctl_io and
struct ctl_scsiio have the same alignment, but this changes on i386 if
a new union member is added that contains a uint64_t member (such as
an embedded struct nvme_command for NVMeoF). In that case, union
ctl_io requires stronger alignment, so the upcast from struct
ctl_scsiio to union ctl_io in ctl_scsi_sense_sbuf raises an increasing
alignment warning on i386.

Avoid the warning by passing struct ctl_io_hdr as the first argument
to ctl_scsi_path_string instead.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable