Page MenuHomeFreeBSD

ctl: Avoid an upcast for calling ctl_scsi_path_string
ClosedPublic

Authored by jhb on Apr 9 2024, 11:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 6, 8:58 AM
Unknown Object (File)
Wed, Oct 29, 10:19 PM
Unknown Object (File)
Wed, Oct 29, 9:16 PM
Unknown Object (File)
Wed, Oct 29, 12:46 AM
Unknown Object (File)
Sun, Oct 26, 8:19 AM
Unknown Object (File)
Sat, Oct 18, 4:29 PM
Unknown Object (File)
Fri, Oct 17, 10:18 PM
Unknown Object (File)
Fri, Oct 17, 6:55 AM
Subscribers
None

Details

Summary

Change the first argument of ctl_scsi_path_string to be the embedded
header structure instead of the union. Currently union ctl_io and
struct ctl_scsiio have the same alignment, but this changes on i386 if
a new union member is added that contains a uint64_t member (such as
an embedded struct nvme_command for NVMeoF). In that case, union
ctl_io requires stronger alignment, so the upcast from struct
ctl_scsiio to union ctl_io in ctl_scsi_sense_sbuf raises an increasing
alignment warning on i386.

Avoid the warning by passing struct ctl_io_hdr as the first argument
to ctl_scsi_path_string instead.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable