Page MenuHomeFreeBSD

nvmf.h: New header defining ioctls for NVMe over Fabrics
AcceptedPublic

Authored by jhb on Tue, Apr 9, 11:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 4:57 AM
Unknown Object (File)
Fri, Apr 12, 6:07 PM
Subscribers

Details

Reviewers
imp
Summary

This defines structures, ioctl commands, and related constants used
for both the Fabrics host and controller.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56997
Build 53885: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Tue, Apr 9, 11:03 PM

One nit... also applies to all of this series of reviews: consider omitting the license boilerplate.

sys/dev/nvme/nvme.h
47

won't line numbers go stale quickly?

This revision is now accepted and ready to land.Sat, Apr 13, 5:53 PM
In D44706#1020670, @imp wrote:

One nit... also applies to all of this series of reviews: consider omitting the license boilerplate.

Hmm, are we ready to do that? I know we have some SPDX-only files in the tree and are kind of allowing it, but I wasn't sure we'd crossed the point to preferring that by default.

sys/dev/nvme/nvme.h
47

Not the line number, the constant 200 as the second argument to _IO*

In D44706#1021491, @jhb wrote:
In D44706#1020670, @imp wrote:

One nit... also applies to all of this series of reviews: consider omitting the license boilerplate.

Hmm, are we ready to do that? I know we have some SPDX-only files in the tree and are kind of allowing it, but I wasn't sure we'd crossed the point to preferring that by default.

hence my suggesting that you consider it: it's an option....

sys/dev/nvme/nvme.h
47

Oh! That's a note for reserved future use...