Differential D44708

nvmf_tcp.h: Internal header shared between userspace and kernel
ClosedPublic
Actions

Authored by jhb on Apr 9 2024, 11:03 PM.

Tags

None

Referenced Files

	F83977849: D44708.diff
	Fri, May 17, 5:28 PM

	Unknown Object (File)
	Fri, May 10, 7:30 AM

	Unknown Object (File)
	Sat, May 4, 5:05 PM

	Unknown Object (File)
	Mon, Apr 29, 7:42 AM

	Unknown Object (File)
	Fri, Apr 26, 4:22 PM

	Unknown Object (File)
	Fri, Apr 26, 4:57 AM

	Unknown Object (File)
	Thu, Apr 25, 11:33 PM

	Unknown Object (File)
	Thu, Apr 25, 6:13 PM

View All 10 Files

Subscribers

None

Details

Reviewers

Commits

rGbbd5b6fe91ec: nvmf_tcp.h: Internal header shared between userspace and kernel

Summary

Helper macros for specific SGL types used with the TCP transport

An inline function which validates various fields in TCP PDUs

Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57131
Build 54019: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Apr 9 2024, 11:03 PM

jhb created this revision.

Harbormaster completed remote builds in B56999: Diff 136804.Apr 9 2024, 11:03 PM

jhb added a parent revision: D44707: nvmf: Install nvmf.h and nvmf_proto.h in /usr/include/dev/nvmf.Apr 9 2024, 11:03 PM

jhb added a child revision: D44709: nvmft: Add NVMeoF controller routines shared between kernel and userland.

generally good, could of nits. see other warnings about nvmf knowledge being weak, so I can only do a cursory review of the code.

sys/dev/nvmf/nvmf_tcp.h
31	guard macro names...
34	I'm surprised we don't define this one in sys/cdefs.h
90	since standard section numbering fluctuates between revisions, maybe it would make sense to have a quick note at the top of this fix documenting what version "Section numbers below are against NVMF standard 1.1" or somesuch.

This revision is now accepted and ready to land.Apr 13 2024, 5:58 PM

jhb marked an inline comment as done.Apr 16 2024, 5:57 PM

jhb added inline comments.

sys/dev/nvmf/nvmf_tcp.h
34	We don't for userspace. That's a kernel-only macro.

Add reference to spec

This revision now requires review to proceed.Apr 16 2024, 8:43 PM

Harbormaster completed remote builds in B57131: Diff 137176.Apr 16 2024, 8:43 PM

imp accepted this revision.Apr 16 2024, 9:00 PM

This revision is now accepted and ready to land.Apr 16 2024, 9:00 PM

Switch to SPDX-only license blocks for C files

This revision now requires review to proceed.Wed, May 1, 10:51 PM

Harbormaster completed remote builds in B57525: Diff 137991.Wed, May 1, 10:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Fri, May 3, 12:16 AM

Closed by commit rGbbd5b6fe91ec: nvmf_tcp.h: Internal header shared between userspace and kernel (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGbbd5b6fe91ec: nvmf_tcp.h: Internal header shared between userspace and kernel.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvmf/

297 lines

Diff 137176

sys/dev/nvmf/nvmf_tcp.h

Loading...