Page MenuHomeFreeBSD

nvmft: Validate the native byte order qid when establishing I/O queues
Needs ReviewPublic

Authored by jhb on Thu, Oct 8, 3:51 PM.
Tags
None
Referenced Files
F175216524: D60474.diff
Fri, Oct 9, 4:30 AM
F175173422: D60474.id189065.diff
Thu, Oct 8, 8:57 PM
F175172689: D60474.diff
Thu, Oct 8, 8:48 PM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This is a no-op on little-endian systems since NVMe uses little-endian
encoding. However, on big-endian systems this could permit
establishing I/O queues with an out-of-bounds index into the
io_qpairs[] array of I/O queue structures. Not only does this corrupt
memory, but a controller shutdown would not find this queue to shut it
down thus leaving it active even after the controller has gone away.

Sponsored by: BSDTrust, Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77858
Build 74741: arc lint + arc unit