libnvmf: Add helper routines to return errors for CONNECT
Needs ReviewPublic
Actions

Authored by jhb on Sat, Nov 14, 5:39 PM.

Project Tags

None

Referenced Files

	F177570737: D61550.1794768269.diff
	Sat, Nov 14, 6:44 PM

	F177570475: D61550.1794767690.diff
	Sat, Nov 14, 6:34 PM

	F177570459: D61550.1794767660.diff
	Sat, Nov 14, 6:34 PM

Subscribers

None

Details

Reviewers

imp
chuck

Summary

Currently the only helpers available for replying to a CONNECT are
nvmf_finish_accept() (to send success) and
nvmf_connect_invalid_parameters() (which sends a command-specific
error).

The nvmf_send_* helpers used for other commands cannot be used for
replies to CONNECT since there is no valid SQHD.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 79140
Build 76023: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Sat, Nov 14, 5:39 PM

jhb created this revision.

jhb added a child revision: D61551: ctld nvmf: Return a generic internal error response if queue handoff fails.

Harbormaster completed remote builds in B79140: Diff 192608.Sat, Nov 14, 5:39 PM

jhb added a parent revision: D60469: libnvmf: Improve handling of the CATTR field in CONNECT commands.Sat, Nov 14, 5:40 PM

Revision Contents
Changeset List

Path

Size

lib/

libnvmf/

libnvmf.h

14 lines

nvmf_controller.c

18 lines

Diff 192608

View Options

lib/libnvmf/libnvmf.h