Differential D34024

ice(4): Update to 1.34.2-k
ClosedPublic
Actions

Authored by erj on Jan 25 2022, 3:09 AM.

Tags

None

Referenced Files

	F160752802: D34024.diff
	Sat, Jun 27, 12:23 PM

	Unknown Object (File)
	Fri, Jun 26, 9:01 PM

	Unknown Object (File)
	Thu, Jun 25, 1:56 AM

	Unknown Object (File)
	Tue, Jun 23, 5:45 PM

	Unknown Object (File)
	Tue, Jun 23, 1:57 AM

	Unknown Object (File)
	Mon, Jun 22, 4:20 PM

	Unknown Object (File)
	Sun, Jun 21, 1:06 PM

	Unknown Object (File)
	Fri, Jun 19, 7:22 PM

Subscribers

jeffrey.e.pieper_intel.com

Details

Reviewers

stallamr_netapp.com
jeffrey.e.pieper_intel.com

Group Reviewers

Intel Networking

Commits

rGb04c95489864: ice(4): Update to 1.34.2-k
rG56429daea255: ice(4): Update to 1.34.2-k
rGa0cdf45ea1d1: ice(4): Update to 1.34.2-k

Summary

Adds FW logging support
- Once enabled, this lets the firmware print event and error messages to the log, increasing the visibility into what the hardware is doing; it's useful for debugging.
General bug fixes
Adds initial DCB support to the driver
- Notably, this adds support for DCBX to the driver -- now with fw_lldp set to 1, the driver and adapter will adopt a DCBX configuration sent from a link partner.
- Add statistics sysctls for priority flow control frames
- Add new configuration sysctls for DCB-related features: user priority to TC mapping, ETS bandwidth allocation, priority flow control
Remove unused SR-IOV files (until support gets added)

Signed-off-by: Eric Joyner <erj@FreeBSD.org>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	sys/dev/ice/ice_iflib_txrx.c:430	SPELL1	Possible Spelling Mistake

Unit

No Test Coverage

Build Status

Buildable 44079
Build 40967: arc lint + arc unit

Event Timeline

erj created this revision.Jan 25 2022, 3:09 AM

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptJan 25 2022, 3:09 AM

erj requested review of this revision.Jan 25 2022, 3:09 AM

Harbormaster completed remote builds in B44079: Diff 101874.Jan 25 2022, 3:09 AM

erj added reviewers: Intel Networking, stallamr_netapp.com.Jan 25 2022, 3:10 AM

erj edited the summary of this revision. (Show Details)Jan 25 2022, 3:13 AM

Fix spelling mistake caught by lint

Harbormaster completed remote builds in B44080: Diff 101875.Jan 25 2022, 3:16 AM

erj added a child revision: D30889: ice(4): Add RDMA Client Interface.Jan 25 2022, 3:24 AM

erj added inline comments.Jan 26 2022, 12:25 AM

sys/dev/ice/ice_iflib_txrx.c
411	This function is now called by iflib in its TX path to determine which queue to output on
sys/dev/ice/ice_lib.c
3760	We've added new DCB configuration sysctls, but these should be documented in an upcoming man page
sys/dev/ice/ice_lib.h
204	FW logging can generate a lot of messages in a short span of time, so this value was increased to the maximum possible one.
574	This state is used to track when multiple traffic classes are in use by the hardware/driver

erj edited the summary of this revision. (Show Details)Jan 26 2022, 12:26 AM

erj added inline comments.Jan 26 2022, 12:35 AM

sys/dev/ice/ice_dcb.c
1471–1604	There is initial support infrastructure in the driver to support DSCP DCB mode, but actual support in the driver is coming later.
sys/dev/ice/ice_iflib_txrx.c
322	Things got shuffled around here in ice_ift_rxd_pkt_get(); some of the code in the for-loop has been moved out of the for-loop because it only applies to the last descriptor in a packet.
329	iflib doesn't handle this case well and it causes issues, but in practice this only seems to happen when adapters are configured to store bad packets which I don't think we currently allow in this driver.
sys/dev/ice/ice_lib.c
7524	This chunk of added code is new for configuring DCB-related things.

erj added a parent revision: D31485: iflib: Allow drivers to determine which queue to TX on.Feb 10 2022, 6:34 PM

bold text

This revision is now accepted and ready to land.Mar 4 2022, 1:12 PM

Closed by commit rGa0cdf45ea1d1: ice(4): Update to 1.34.2-k (authored by erj). · Explain WhyMar 25 2022, 8:45 PM

This revision was automatically updated to reflect the committed changes.

erj added a commit: rGa0cdf45ea1d1: ice(4): Update to 1.34.2-k.

erj added a commit: rG56429daea255: ice(4): Update to 1.34.2-k.

erj added a commit: rGb04c95489864: ice(4): Update to 1.34.2-k.Apr 9 2023, 12:01 AM

Revision Contents
Changeset List

Path

Size

sys/

conf/

6 lines

8 lines

6 lines

dev/

ice/

ice_adminq_cmd.h

175 lines

47 lines

723 lines

21 lines

212 lines

12 lines

25 lines

2 lines

ice_flex_pipe.c

14 lines

ice_flex_type.h

4 lines

9 lines

46 lines

ice_fw_logging.c

425 lines

91 lines

505 lines

ice_hw_autogen.h

148 lines

6 lines

ice_iflib_txrx.c

84 lines

ice_lan_tx_rx.h

27 lines

39 lines

1648 lines

13 lines

69 lines

2 lines

36 lines

ice_protocol_type.h

14 lines

63 lines

130 lines

12 lines

73 lines

83 lines

ice_vlan_mode.h

2 lines

ice_vlan_mode.c

86 lines

42 lines

611 lines

virtchnl_inline_ipsec.h

36 lines

virtchnl_lan_desc.h

289 lines

modules/

ice/

3 lines

Diff 101874

sys/conf/files.amd64

Loading...

sys/conf/files.arm64

Loading...

sys/conf/files.powerpc

Loading...

sys/dev/ice/ice_adminq_cmd.h

Loading...

sys/dev/ice/ice_common.h

Loading...

sys/dev/ice/ice_common.c

Loading...

sys/dev/ice/ice_dcb.h

Loading...

sys/dev/ice/ice_dcb.c

Loading...

sys/dev/ice/ice_devids.h

Loading...

sys/dev/ice/ice_drv_info.h

Loading...

sys/dev/ice/ice_features.h

Loading...

sys/dev/ice/ice_flex_pipe.c

Loading...

sys/dev/ice/ice_flex_type.h

Loading...

sys/dev/ice/ice_flow.h

Loading...

sys/dev/ice/ice_flow.c

Loading...

sys/dev/ice/ice_fw_logging.c

Loading...

sys/dev/ice/ice_fwlog.h

Loading...

sys/dev/ice/ice_fwlog.c

Loading...

sys/dev/ice/ice_hw_autogen.h

Loading...

sys/dev/ice/ice_iflib.h

Loading...

sys/dev/ice/ice_iflib_txrx.c

Loading...

sys/dev/ice/ice_lan_tx_rx.h

Loading...

sys/dev/ice/ice_lib.h

Loading...

sys/dev/ice/ice_lib.c

Loading...

sys/dev/ice/ice_nvm.h

Loading...

sys/dev/ice/ice_nvm.c

Loading...

sys/dev/ice/ice_osdep.h

Loading...

sys/dev/ice/ice_osdep.c

Loading...

sys/dev/ice/ice_protocol_type.h

Loading...

sys/dev/ice/ice_sched.c

Loading...

sys/dev/ice/ice_sriov.h

Loading...

sys/dev/ice/ice_sriov.c

Loading...

sys/dev/ice/ice_strings.c

Loading...

sys/dev/ice/ice_switch.h

Loading...

sys/dev/ice/ice_switch.c

Loading...

sys/dev/ice/ice_type.h

Loading...

sys/dev/ice/ice_vlan_mode.h

Loading...

sys/dev/ice/ice_vlan_mode.c

Loading...

sys/dev/ice/if_ice_iflib.c

Loading...

sys/dev/ice/virtchnl.h

Loading...

sys/dev/ice/virtchnl_inline_ipsec.h

Loading...

sys/dev/ice/virtchnl_lan_desc.h

Loading...

sys/modules/ice/Makefile

Loading...