Only build USB-related modules if MK_USB != no
Needs ReviewPublic
Actions

Authored by ngie on Fri, Feb 27, 9:02 PM.

Details

Reviewers

Summary

This change moves the thunderbolt module and other USB modules under a
MK_USB != no conditional to ensure that users not desiring USB support
can build systems without USB-specific drivers.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71086
Build 67969: arc lint + arc unit

Event Timeline

ngie created this revision.Fri, Feb 27, 9:02 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Feb 27, 9:02 PM

ngie requested review of this revision.Fri, Feb 27, 9:02 PM

Harbormaster completed remote builds in B71083: Diff 172895.Fri, Feb 27, 9:02 PM

ngie added inline comments.Fri, Feb 27, 9:04 PM

sys/modules/Makefile
949–954	This went missing when resolving a merge conflict on my branch after shuffling the stack around. This wasn't intentional.

ngie added a reviewer: imp.Fri, Feb 27, 9:04 PM

ngie removed a subscriber: imp.

ngie added subscribers: dab, vangyzen, bdrewery, USB.

So there's two competing mechanism now for usb: the kernel config file (which better not be setting this) and the user WITH/WITHOUT mechanism. This is a bit weird and novel for the kernel and may or may not be easy to support in configng.

This revision is now accepted and ready to land.Fri, Feb 27, 9:07 PM

Sorry but where are _rtwn_usb and _usb defined now?