Page MenuHomeFreeBSD
Differential D50913

newbus: replace leftover device unit wildcards
ClosedPublic
Actions

Authored by vexeduxr on Jun 18 2025, 2:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 2:36 AM
Unknown Object (File)
Sat, Oct 4, 10:41 PM
Unknown Object (File)
Sep 6 2025, 1:44 AM
Unknown Object (File)
Aug 12 2025, 2:10 PM
Unknown Object (File)
Aug 5 2025, 10:04 AM
Unknown Object (File)
Aug 2 2025, 4:05 AM
Unknown Object (File)
Jul 28 2025, 9:16 AM
Unknown Object (File)
Jul 23 2025, 10:41 AM
View All 27 Files
Subscribers
ae
dab
dsl
emaste
jhibbits
olce
linuxkpi
riscv

Details

Reviewers
imp
jhb
andrew
manu
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rGb670c9bafc0e: newbus: replace leftover device unit wildcards
Test Plan

Found with the following regex:
'BUS_ADD_CHILD\(.*, .*, -1\)|device_add_child\(.*, .*, -1\)|device_find_child\(.*, .*, -1\)|resource_.*_value\(.*, -1'

I also found bhndb_attach_bridge and ofw_pwmbus_add_child manually.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64951
Build 61834: arc lint + arc unit

Event Timeline

vexeduxr created this revision.Jun 18 2025, 2:51 AM
Owners added a reviewer: Restricted Owners Package.Jun 18 2025, 2:51 AM
Herald added a reviewer: andrew. · View Herald TranscriptJun 18 2025, 2:51 AM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: riscv, linuxkpi, olce and 4 others. · View Herald Transcript
vexeduxr requested review of this revision.Jun 18 2025, 2:51 AM
Herald added a subscriber: dsl. · View Herald TranscriptJun 18 2025, 2:51 AM
Harbormaster completed remote builds in B64951: Diff 157250.Jun 18 2025, 2:51 AM
vexeduxr edited the test plan for this revision. (Show Details)Jun 18 2025, 2:56 AM
imp accepted this revision.Jun 18 2025, 4:23 AM

The spot checks look good. I'd wait for jhb to double check.

This revision is now accepted and ready to land.Jun 18 2025, 4:23 AM
jhb accepted this revision.Jun 20 2025, 5:25 PM
vexeduxr closed this revision.Jun 21 2025, 3:26 AM

Landed as rGb670c9bafc0e31c7609969bf374b2e80bdc00211. I think I messed up the Differential Revision: tag.

jrtc27 added a commit: rGb670c9bafc0e: newbus: replace leftover device unit wildcards.Jun 21 2025, 4:27 AM

Revision Contents
Changeset List

PathSize
share/
examples/
drivers/
3 lines
stand/
kshim/
5 lines
sys/
arm/
broadcom/
bcm2835/
4 lines
nvidia/
tegra124/
4 lines
4 lines
ti/
am335x/
3 lines
2 lines
3 lines
arm64/
arm64/
2 lines
2 lines
cavium/
2 lines
nvidia/
tegra210/
4 lines
4 lines
compat/
linuxkpi/
common/
src/
5 lines
5 lines
crypto/
aesni/
4 lines
armv8/
4 lines
blake2/
4 lines
openssl/
2 lines
via/
4 lines
dev/
aac/
2 lines
acpi_support/
4 lines
4 lines
4 lines
acpica/
2 lines
2 lines
6 lines
2 lines
agp/
2 lines
amdsbwd/
5 lines
amdsmn/
2 lines
amdtemp/
2 lines
atopcase/
2 lines
bhnd/
2 lines
cores/
chipc/
6 lines
bwn/
2 lines
chromebook_platform/
2 lines
coretemp/
2 lines
cpufreq/
2 lines
8 lines
cxgb/
3 lines
cxgbe/
crypto/
2 lines
dpaa2/
2 lines
4 lines
2 lines
efidev/
4 lines
etherswitch/
e6000sw/
2 lines
2 lines
ip17x/
2 lines
2 lines
rtl8366/
2 lines
firewire/
2 lines
glxiic/
7 lines
gpio/
2 lines
hid/
2 lines
hyperv/
input/
2 lines
vmbus/
2 lines
ichsmb/
3 lines
iicbus/
controller/
cadence/
2 lines
twsi/
3 lines
2 lines
2 lines
ipmi/
2 lines
2 lines
isl/
2 lines
ismt/
3 lines
kvm_clock/
2 lines
mdio/
2 lines
mfi/
6 lines
2 lines
mmcnull/
2 lines
nvdimm/
2 lines
nvmf/
host/
2 lines
p2sb/
2 lines
pcf/
2 lines
pci/
2 lines
ppbus/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
psci/
2 lines
2 lines
pwm/
6 lines
qat/
qat/
4 lines
qcom_qup/
2 lines
sdio/
2 lines
smbus/
2 lines
sound/
4 lines
pci/
2 lines
spibus/
2 lines
superio/
2 lines
usb/
misc/
2 lines
viapm/
2 lines
viawd/
2 lines
virtio/
mmio/
2 lines
isa/
3 lines
kern/
5 lines
opencrypto/
2 lines
powerpc/
cpufreq/
4 lines
4 lines
4 lines
4 lines
4 lines
powermac/
2 lines
2 lines
powernv/
3 lines
ps3/
2 lines
2 lines
riscv/
riscv/
2 lines
6 lines
x86/
cpufreq/
10 lines
5 lines
2 lines
2 lines
5 lines
8 lines
pci/
2 lines

Diff 157250

View Options

share/examples/drivers/make_device_driver.sh

Loading...
View Options

stand/kshim/bsd_kernel.c

Loading...
View Options

sys/arm/broadcom/bcm2835/bcm2835_cpufreq.c

Loading...
View Options

sys/arm/nvidia/tegra124/tegra124_coretemp.c

Loading...
View Options

sys/arm/nvidia/tegra124/tegra124_cpufreq.c

Loading...
View Options

sys/arm/ti/am335x/am335x_ehrpwm.c

Loading...
View Options

sys/arm/ti/am335x/am335x_scm.c

Loading...
View Options

sys/arm/ti/ti_i2c.c

Loading...
View Options

sys/arm64/arm64/gic_v3_acpi.c

Loading...
View Options

sys/arm64/arm64/gic_v3_fdt.c

Loading...
View Options

sys/arm64/cavium/thunder_pcie_fdt.c

Loading...
View Options

sys/arm64/nvidia/tegra210/tegra210_coretemp.c

Loading...
View Options

sys/arm64/nvidia/tegra210/tegra210_cpufreq.c

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_i2c.c

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_i2cbb.c

Loading...
View Options

sys/crypto/aesni/aesni.c

Loading...
View Options

sys/crypto/armv8/armv8_crypto.c

Loading...
View Options

sys/crypto/blake2/blake2_cryptodev.c

Loading...
View Options

sys/crypto/openssl/ossl.c

Loading...
View Options

sys/crypto/via/padlock.c

Loading...
View Options

sys/dev/aac/aac.c

Loading...
View Options

sys/dev/acpi_support/acpi_asus_wmi.c

Loading...
View Options

sys/dev/acpi_support/acpi_hp.c

Loading...
View Options

sys/dev/acpi_support/acpi_sbl_wmi.c

Loading...
View Options

sys/dev/acpica/acpi_pcib_acpi.c

Loading...
View Options

sys/dev/acpica/acpi_perf.c

Loading...
View Options

sys/dev/acpica/acpi_throttle.c

Loading...
View Options

sys/dev/acpica/acpi_video.c

Loading...
View Options

sys/dev/agp/agp_i810.c

Loading...
View Options

sys/dev/amdsbwd/amdsbwd.c

Loading...
View Options

sys/dev/amdsmn/amdsmn.c

Loading...
View Options

sys/dev/amdtemp/amdtemp.c

Loading...
View Options

sys/dev/atopcase/atopcase.c

Loading...
View Options

sys/dev/bhnd/bhnd_subr.c

Loading...
View Options

sys/dev/bhnd/cores/chipc/chipc_spi.c

Loading...
View Options

sys/dev/bwn/if_bwn_pci.c

Loading...
View Options

sys/dev/chromebook_platform/chromebook_platform.c

Loading...
View Options

sys/dev/coretemp/coretemp.c

Loading...
View Options

sys/dev/cpufreq/cpufreq_dt.c

Loading...
View Options

sys/dev/cpufreq/ichss.c

Loading...
View Options

sys/dev/cxgb/cxgb_main.c

Loading...
View Options

sys/dev/cxgbe/crypto/t4_crypto.c

Loading...
View Options

sys/dev/dpaa2/dpaa2_mc_acpi.c

Loading...
View Options

sys/dev/dpaa2/dpaa2_rc.c

Loading...
View Options

sys/dev/dpaa2/memac_mdio_acpi.c

Loading...
View Options

sys/dev/efidev/efirtc.c

Loading...
View Options

sys/dev/etherswitch/e6000sw/e6000sw.c

Loading...
View Options

sys/dev/etherswitch/etherswitch.c

Loading...
View Options

sys/dev/etherswitch/ip17x/ip17x.c

Loading...
View Options

sys/dev/etherswitch/miiproxy.c

Loading...
View Options

sys/dev/etherswitch/rtl8366/rtl8366rb.c

Loading...
View Options

sys/dev/firewire/sbp.c

Loading...
View Options

sys/dev/glxiic/glxiic.c

Loading...
View Options

sys/dev/gpio/gpiobus.c

Loading...
View Options

sys/dev/hid/hidraw.c

Loading...
View Options

sys/dev/hyperv/input/hv_hid.c

Loading...
View Options

sys/dev/hyperv/vmbus/vmbus_et.c

Loading...
View Options

sys/dev/ichsmb/ichsmb.c

Loading...
View Options

sys/dev/iicbus/controller/cadence/cdnc_i2c.c

Loading...
View Options

sys/dev/iicbus/controller/twsi/twsi.c

Loading...
View Options

sys/dev/iicbus/iic.c

Loading...
View Options

sys/dev/iicbus/iicsmb.c

Loading...
View Options

sys/dev/ipmi/ipmi_isa.c

Loading...
View Options

sys/dev/ipmi/ipmi_smbus.c

Loading...
View Options

sys/dev/isl/isl.c

Loading...
View Options

sys/dev/ismt/ismt.c

Loading...
View Options

sys/dev/kvm_clock/kvm_clock.c

Loading...
View Options

sys/dev/mdio/mdio.c

Loading...
View Options

sys/dev/mfi/mfi.c

Loading...
View Options

sys/dev/mfi/mfi_cam.c

Loading...
View Options

sys/dev/mmcnull/mmcnull.c

Loading...
View Options

sys/dev/nvdimm/nvdimm_e820.c

Loading...
View Options

sys/dev/nvmf/host/nvmf_ctldev.c

Loading...
View Options

sys/dev/p2sb/lewisburg_gpiocm.c

Loading...
View Options

sys/dev/pcf/pcf_isa.c

Loading...
View Options

sys/dev/pci/pci_host_generic_den0115.c

Loading...
View Options

sys/dev/ppbus/if_plip.c

Loading...
View Options

sys/dev/ppbus/lpbb.c

Loading...
View Options

sys/dev/ppbus/lpt.c

Loading...
View Options

sys/dev/ppbus/pcfclock.c

Loading...
View Options

sys/dev/ppbus/ppi.c

Loading...
View Options

sys/dev/ppbus/pps.c

Loading...
View Options

sys/dev/psci/smccc_errata.c

Loading...
View Options

sys/dev/psci/smccc_trng.c

Loading...
View Options

sys/dev/pwm/ofw_pwmbus.c

Loading...
View Options

sys/dev/qat/qat/qat_ocf.c

Loading...
View Options

sys/dev/qcom_qup/qcom_spi.c

Loading...
View Options

sys/dev/sdio/sdiob.c

Loading...
View Options

sys/dev/smbus/smb.c

Loading...
View Options

sys/dev/sound/dummy.c

Loading...
View Options

sys/dev/sound/pci/hdsp.c

Loading...
View Options

sys/dev/spibus/acpi_spibus.c

Loading...
View Options

sys/dev/superio/superio.c

Loading...
View Options

sys/dev/usb/misc/i2ctinyusb.c

Loading...
View Options

sys/dev/viapm/viapm.c

Loading...
View Options

sys/dev/viawd/viawd.c

Loading...
View Options

sys/dev/virtio/mmio/virtio_mmio.c

Loading...
View Options

sys/isa/isahint.c

Loading...
View Options

sys/kern/kern_cpu.c

Loading...
View Options

sys/opencrypto/cryptosoft.c

Loading...
View Options

sys/powerpc/cpufreq/dfs.c

Loading...
View Options

sys/powerpc/cpufreq/mpc85xx_jog.c

Loading...
View Options

sys/powerpc/cpufreq/pcr.c

Loading...
View Options

sys/powerpc/cpufreq/pmcr.c

Loading...
View Options

sys/powerpc/cpufreq/pmufreq.c

Loading...
View Options

sys/powerpc/powermac/atibl.c

Loading...
View Options

sys/powerpc/powermac/nvbl.c

Loading...
View Options

sys/powerpc/powernv/opal_i2c.c

Loading...
View Options

sys/powerpc/ps3/ps3bus.c

Loading...
View Options

sys/powerpc/ps3/ps3pic.c

Loading...
View Options

sys/riscv/riscv/intc.c

Loading...
View Options

sys/riscv/riscv/sbi.c

Loading...
View Options

sys/x86/cpufreq/est.c

Loading...
View Options

sys/x86/cpufreq/hwpstate_amd.c

Loading...
View Options

sys/x86/cpufreq/hwpstate_intel.c

Loading...
View Options

sys/x86/cpufreq/p4tcc.c

Loading...
View Options

sys/x86/cpufreq/powernow.c

Loading...
View Options

sys/x86/cpufreq/smist.c

Loading...
View Options

sys/x86/pci/qpi.c

Loading...