Page MenuHomeFreeBSD

Comprehensive changes for vendored openzfs
Needs ReviewPublic

Authored by mmacy on Wed, Jul 29, 12:31 AM.

Details

Summary

Make ZFS build with openzfs sources, update dtrace build to coexist

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mmacy created this revision.Wed, Jul 29, 12:31 AM
mmacy requested review of this revision.Wed, Jul 29, 12:32 AM
kevans added a subscriber: kevans.Wed, Jul 29, 2:23 AM
kevans added inline comments.
cddl/lib/libzfs/Makefile
11–12

I think we should consider installing libzfs/libzfs.h here as well in the new world order.

jhb added a subscriber: jhb.Wed, Jul 29, 11:43 PM
jhb added inline comments.
sys/kern/genoffset.c
35 ↗(On Diff #75097)

Normally this would go after <sys/assym.h>?

linimon added a subscriber: linimon.Tue, Aug 4, 3:33 AM
mmacy updated this revision to Diff 75392.Tue, Aug 4, 7:48 PM

Rebase and remove header in response to feedback

mmacy updated this revision to Diff 75393.Tue, Aug 4, 7:52 PM
mmacy marked an inline comment as done.Tue, Aug 4, 7:55 PM
mmacy added inline comments.
cddl/lib/libzfs/Makefile
11–12

I think we should consider installing libzfs/libzfs.h here as well in the new world order.

libzfs is a private library that is subject to constant churn. Anything we want from it should be moved in to libzfs_core.

sys/kern/genoffset.c
35 ↗(On Diff #75097)

Normally this would go after <sys/assym.h>?

I removed the added header. Something is wrong with phab in that it still shows the change in the diff.