i feel like this is really an issue in makefs: if it doesn't know the permissions for a directory, it should fail with an error, since 0 permissions is almost certainly going to be wrong. ideally, it would sort the METALOG itself to handle cases like this, although i don't know if that breaks anything else.

Add -u which got lost when I committed the wrong patch.

I have ambivalent feelings:

Looks good for me

ok, I'd like to land this and then follow it up with some more iwx cleanups. Thanks for pointing them out though, I'm not shocked that the original upstream code was messy with key management too. ;-)

Address review feedback; use stat -h and stop asserting on hole reporting

In D53026#1211786, @des wrote:

@mjg @kib do you agree that there is no reason why the userland implementation of realpath() would succeed after the syscall failed, except in the case of a race?

I intend to commit this early next week.

Bug fixes after Peter' testing.