@ziaee I tested the LSI SAS 3908 (MegaRAID 9560 8i), with 14.3-RELEASE. The mrsas driver is automatically loaded, it works with either JBOD mode or RAID0. However, after devctl detach -f and devctl set driver -f device mpr, devctl responded with "device not configured". Even with hint.mpr.0.at="pcix:y:z" in device.hints, the mrsas driver will be loaded instead of the mpr one. In my test, mpr driver does not support SAS 3908, at least with the current firmware.

In D50825#1205587, @glebius wrote:

JFYI, for counter(9) this is all what is needed:

define counter_fetch
  set $sum = 0
  set $c = (uintptr_t )$arg0 + (uintptr_t )&__pcpu[0]
  set $n = 0
  while ( $n < mp_ncpus )
    set $sum = $sum + *(uint64_t *)$c
    set $c = (uint64_t *)((char *)$c + sizeof(struct pcpu))
    set $n = $n + 1  
  end
  p/u $sum
end
document counter_fetch
display a counter_u64 value
end

15.0 is approaching, so I think we can go ahead and commit and work some of the issues I raised lately while in tree?

JFYI, for counter(9) this is all what is needed:

define counter_fetch
  set $sum = 0
  set $c = (uintptr_t )$arg0 + (uintptr_t )&__pcpu[0]
  set $n = 0
  while ( $n < mp_ncpus )
    set $sum = $sum + *(uint64_t *)$c
    set $c = (uint64_t *)((char *)$c + sizeof(struct pcpu))
    set $n = $n + 1  
  end
  p/u $sum
end
document counter_fetch
display a counter_u64 value
end

Address Ed's comment.

In D50825#1205382, @kp wrote:

I may be holding it wrong, but it still breaks for me:
It's a panic in vnet shutdown, so perhaps it's related to that:

(kgdb) bt
#0  __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:57
#1  doadump (textdump=textdump@entry=0) at /usr/src/sys/kern/kern_shutdown.c:399
#2  0xffffffff804aaeba in db_dump (dummy=<optimized out>, dummy2=<optimized out>, dummy3=<optimized out>, dummy4=<optimized out>) at /usr/src/sys/ddb/db_command.c:596
#3  0xffffffff804aacad in db_command (last_cmdp=<optimized out>, cmd_table=<optimized out>, dopager=true) at /usr/src/sys/ddb/db_command.c:508
#4  0xffffffff804aa96d in db_command_loop () at /usr/src/sys/ddb/db_command.c:555
#5  0xffffffff804ae366 in db_trap (type=<optimized out>, code=<optimized out>) at /usr/src/sys/ddb/db_main.c:267
#6  0xffffffff80bdea1f in kdb_trap (type=type@entry=3, code=code@entry=0, tf=tf@entry=0xfffffe002fa705d0) at /usr/src/sys/kern/subr_kdb.c:790
#7  0xffffffff810e04eb in trap (frame=<optimized out>) at /usr/src/sys/amd64/amd64/trap.c:614
#8  <signal handler called>
#9  kdb_enter (why=<optimized out>, msg=<optimized out>) at /usr/src/sys/kern/subr_kdb.c:556
#10 0xffffffff80b8e7bb in vpanic (fmt=0xffffffff8372daba "foo", ap=ap@entry=0xfffffe002fa70800) at /usr/src/sys/kern/kern_shutdown.c:962
#11 0xffffffff80b8e623 in panic (fmt=0xffffffff81d9fab0 <cnputs_mtx> "bm\034\201\377\377\377\377") at /usr/src/sys/kern/kern_shutdown.c:887
#12 0xffffffff836d9722 in pf_sctp_multihome_detach_addr (s=0xfffff806ce77f480) at /usr/src/sys/netpfil/pf/pf.c:7415
#13 pf_detach_state (s=0xfffff806ce77f480) at /usr/src/sys/netpfil/pf/pf.c:1601
#14 0xffffffff836db623 in pf_remove_state (s=0xfffff806ce77f480) at /usr/src/sys/netpfil/pf/pf.c:2857
#15 0xffffffff837048ed in pf_clear_all_states () at /usr/src/sys/netpfil/pf/pf_ioctl.c:6181
#16 0xffffffff837039f5 in shutdown_pf () at /usr/src/sys/netpfil/pf/pf_ioctl.c:6665
#17 pf_unload_vnet () at /usr/src/sys/netpfil/pf/pf_ioctl.c:7011
#18 vnet_pf_uninit (unused=<optimized out>) at /usr/src/sys/netpfil/pf/pf_ioctl.c:7119
#19 0xffffffff80d136c4 in vnet_sysuninit () at /usr/src/sys/net/vnet.c:640
#20 vnet_destroy (vnet=0xfffff8012f7e4180) at /usr/src/sys/net/vnet.c:295
#21 0xffffffff80b483b9 in prison_deref (pr=<optimized out>, flags=67) at /usr/src/sys/kern/kern_jail.c:3576
#22 0xffffffff80bf7ae2 in taskqueue_run_locked (queue=queue@entry=0xfffff80004407a00) at /usr/src/sys/kern/subr_taskqueue.c:517
#23 0xffffffff80bf89d3 in taskqueue_thread_loop (arg=arg@entry=0xffffffff81da08a8 <taskqueue_jail_remove>) at /usr/src/sys/kern/subr_taskqueue.c:829
#24 0xffffffff80b3e042 in fork_exit (callout=0xffffffff80bf8900 <taskqueue_thread_loop>, arg=0xffffffff81da08a8 <taskqueue_jail_remove>, frame=0xfffffe002fa70f40)
    at /usr/src/sys/kern/kern_fork.c:1155
#25 <signal handler called>
(kgdb) p $V("pf_sctp_endpoints")
Python Exception <class 'gdb.error'>: There is no member named origaddr.
Error occurred in Python: There is no member named origaddr.
(kgdb) p $V("pf_status")
Python Exception <class 'gdb.error'>: There is no member named origaddr.
Error occurred in Python: There is no member named origaddr.

Thanks!

Approved.

Approved.

The current logic looks like it was effectively rounding the elapsed time to the nearest hour (with a 30-minute bias). That means a file only 30 minutes old could be considered "1 hour old," which isn’t what a user would normally expect if they configured rotation every hour. A user would reasonably expect “1h” to mean exactly 60 minutes, with perhaps a small tolerance for cron jitter or a slow rotation run.

Approved as talked about yesterday.

Changes are done according to comments.

Also Relnotes!

MFC?

Looks good to me. Thanks for working in it!

LDFLAGS+= -L in lib/:

lib/atf/libatf-c++/Makefile:LDFLAGS+=   -L${.OBJDIR:H}/libatf-c
lib/csu/tests/dynamiclib/Makefile:LDFLAGS+=     -Wl,-rpath,${TESTSDIR} -L${.OBJDIR:H}/dso
lib/googletest/gmock/Makefile:LDFLAGS+= -L${.OBJDIR:H}/gtest
lib/googletest/gmock_main/Makefile:LDFLAGS+=    -L${LIBGTESTDIR}
lib/googletest/gmock_main/Makefile:LDFLAGS+=    -L${LIBGMOCKDIR}
lib/googletest/gtest_main/Makefile:LDFLAGS+=    -L${LIBGTESTDIR}
lib/libc/tests/stdlib/Makefile:LDFLAGS.$t+=     -L${LIBNETBSD_OBJDIR}
lib/libc/tests/tls/Makefile:LDFLAGS.tls_dynamic_test+=  -Wl,-rpath,${TESTSDIR} -L${DSODIR}
lib/libthr/tests/dlopen/Makefile:LDFLAGS+=      -L${.OBJDIR}/dso -Wl,-rpath=${TESTDIR}
lib/libxo/encoder/csv/Makefile:LDFLAGS += -L${.OBJDIR:H:H}/libxo

I see, in

Right, I remember disabling txcsum, which didn't take affect, because hwassist wasn't updated. The patch seems to solve this issue. Thanks!

Thank you for your submission. A few updates suggested for syntax fixes.