Differential D49959

wpa_supplicant: Handle systems without INET (legacy IP) support
ClosedPublic
Actions

Authored by zarychtam_plan-b.pwste.edu.pl on Apr 22 2025, 1:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 15, 12:48 AM

	Unknown Object (File)
	Tue, Oct 14, 1:18 AM

	Unknown Object (File)
	Thu, Oct 9, 8:01 PM

	Unknown Object (File)
	Sun, Sep 28, 12:36 PM

	Unknown Object (File)
	Thu, Sep 25, 1:20 PM

	Unknown Object (File)
	Sep 14 2025, 3:13 AM

	Unknown Object (File)
	Sep 14 2025, 2:24 AM

	Unknown Object (File)
	Sep 13 2025, 4:33 AM

View All 52 Files

Subscribers

roy_marples.name

Details

Reviewers

cy
bz
adrian
philip
roy_marples.name

Group Reviewers

Commits

rGdb9d0fad461a: wpa_supplicant: Handle systems without INET (legacy IP) support
rGb3e677d58b7a: wpa_supplicant: Handle systems without INET (legacy IP) support
rG8c7149c73f8f: wpa_supplicant: Handle systems without INET (legacy IP) support

Summary

Currently, wpa_supplicant fails when legacy IP support is disabled in FreeBSD (i.e., the world built with WITHOUT_INET and nooptions INET in the kernel config). The proposed patch allows running wpa_supplicant and connecting to wireless networks without INET support when INET6 is available.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zarychtam_plan-b.pwste.edu.pl requested review of this revision.Apr 22 2025, 1:39 PM

zarychtam_plan-b.pwste.edu.pl created this revision.

I think this is fine for now. Ouch. ;-)

This revision is now accepted and ready to land.Apr 22 2025, 3:35 PM

Thank you for the support @adrian.
I am adding @roy_marples.name as a reviewer, he has deep insight since contributed a lot to this project.
The patch was submitted to the upstream and is awaiting acceptance.

LGTM.

Tested on NetBSD-10 just by changing PF_INET TO PF_INET6 and it works just as before.

bz requested changes to this revision.Apr 22 2025, 7:49 PM

bz added inline comments.

contrib/wpa/src/drivers/driver_bsd.c
1803	Why EPROTONOSUPPORT? SOCK_DRAM being a problem you'd have to try SOCK_STREAM?
1804	Indentation looks wrong for the inside of this block.

This revision now requires changes to proceed.Apr 22 2025, 7:49 PM

Improved readability (indentations adjusted), unused condition removed.

zarychtam_plan-b.pwste.edu.pl marked 2 inline comments as done.Apr 22 2025, 9:00 PM

Looks good to me. Thank you for addressing @bz's comments.

LGTM following bz@'s suggestion.

cy accepted this revision.Apr 28 2025, 12:04 AM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2025, 12:05 AM

Closed by commit rG8c7149c73f8f: wpa_supplicant: Handle systems without INET (legacy IP) support (authored by zarychtam_plan-b.pwste.edu.pl, committed by cy). · Explain Why

This revision was automatically updated to reflect the committed changes.

cy added a commit: rG8c7149c73f8f: wpa_supplicant: Handle systems without INET (legacy IP) support.

Herald added a subscriber: imp. · View Herald TranscriptApr 28 2025, 12:05 AM

cy mentioned this in D50050: wpa_supplicant: Use PF_LOCAL instead of PF_INET*.Apr 28 2025, 2:03 AM

cy added a commit: rGb3e677d58b7a: wpa_supplicant: Handle systems without INET (legacy IP) support.May 11 2025, 4:50 AM

cy added a commit: rGdb9d0fad461a: wpa_supplicant: Handle systems without INET (legacy IP) support.

Revision Contents
Changeset List

Path

Size

contrib/

wpa/

src/

drivers/

10 lines

Diff 154367

contrib/wpa/src/drivers/driver_bsd.c

Loading...