Page MenuHomeFreeBSD
Differential D49817

mbuf: add mbuf information to KASSERTs
ClosedPublic
Actions

Authored by bz on Apr 13 2025, 11:11 PM.
Tags
None
Referenced Files
F133182145: D49817.id153622.diff
Thu, Oct 23, 6:14 PM
Unknown Object (File)
Mon, Oct 20, 12:02 AM
Unknown Object (File)
Wed, Oct 15, 6:55 AM
Unknown Object (File)
Wed, Oct 8, 6:56 PM
Unknown Object (File)
Sun, Oct 5, 12:42 PM
Unknown Object (File)
Sep 23 2025, 6:16 PM
Unknown Object (File)
Sep 11 2025, 4:59 PM
Unknown Object (File)
Sep 11 2025, 2:23 AM
View All 54 Files
Subscribers
glebius
imp
zlei

Details

Reviewers
glebius
zlei
Group Reviewers
network
Commits
rG95e956722a2e: mbuf: add mbuf information to KASSERTs
rG22d5d61f91eb: mbuf: add mbuf information to KASSERTs
Summary

Be more consistent about printing the mbuf pointer in KASSERT messages.
This massively helps debugging and we were already doing a good job at
it.

Also replace some handrolled KASSERTs with M_ASSERTPKTHDR() for fewer
copies of the check logic.

In m_align() move the msg into the KASSERT given after it was moved
here in ed6a66ca6c206 the msg is only used in one place.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Apr 13 2025, 11:11 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 13 2025, 11:11 PM
bz requested review of this revision.Apr 13 2025, 11:11 PM
Harbormaster completed remote builds in B63490: Diff 153622.Apr 13 2025, 11:11 PM
glebius accepted this revision as: glebius.Apr 14 2025, 6:53 PM
glebius added a subscriber: glebius.

Thanks! Definitely will speed up analyzing crashes when debugger fails to figure out which register holds the pointer.

This revision is now accepted and ready to land.Apr 14 2025, 6:53 PM
zlei accepted this revision as: zlei.Apr 15 2025, 3:02 AM
zlei added a subscriber: zlei.

Looks good to me.

Closed by commit rG22d5d61f91eb: mbuf: add mbuf information to KASSERTs (authored by bz). · Explain WhyApr 22 2025, 8:04 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG22d5d61f91eb: mbuf: add mbuf information to KASSERTs.
bz added a commit: rG95e956722a2e: mbuf: add mbuf information to KASSERTs.Apr 29 2025, 11:42 AM

Revision Contents
Changeset List

PathSize
sys/
sys/
29 lines

Diff 154119

View Options

sys/sys/mbuf.h

Loading...