Full build tests and run-time tests look good here. Thanks. I'll commit.

In D36639#832210, @diizzy wrote:

Please use the PR, no need to open a phab review

Please use the PR, no need to open a phab review

• Added "spotify-player" to audio/Makefile
• Removed "A" from start of COMMENT
• Updated pkg-descr to wrap lines after 80 characters

In D36645#832058, @jfree wrote:

During my testing of this port, I found that poudriere-devel has a testport -b [branch] flag that
prefetches most dependencies as packages through the pkg repos.

This was especially useful for this port because Rust takes ~1-2 hours to build on my
machine. Perhaps you already know about this flag, but I thought I would bring it up
because it made my life a lot easier.

Joe, thank you for taking a look at this. I will fix up those issues by the end of the day.

Looks great other than these little nit-picks. An entry in audio/Makefile is also required.

Abandoning as I lack mental energy to respond to possible comments, and I'm probably no longer interested in FreeBSD.
This has nothing to do with this review, this is just accumulated. Feel free to pickup the revision if you are interested.

• portfmt run

• removed CMake build type definition
• removed forgotten _IMPLIES
• added net-im/Makefile entry

Moin moin

Patch committed. Thanks for your contribution!

Thank you @tagattie !

Thanks for the head up and sorry for getting back this late.

@tagattie any plan to review this?

Committed, thanks for the patience!

Thank you! :)

In D30045#727389, @a.wolk_fudosecurity.com wrote:

@meta Unfortunately I don't have a commit bit. Who can I ask to commit the change?

@meta Unfortunately I don't have a commit bit. Who can I ask to commit the change?

I have already approved this. Feel free to commit with commit message Approved by: meta (maintainer).

Looks OK from ports/ POV and this port doesn't have a maintainer. I remember deciding against using _SC_HOST_NAME_MAX due to being too error-prone in one of my ports.

This port has a maintainer. Assigning as reviewer.

This is the commit message that phrabricator silently removed:

New Changes;
Added DIST_SUBDIR
Download Maven deps from GitHub with more descriptive filename (mesos-maven-deps-1.10.0.tar.gz)

I've updated the patch to pull all the required Maven dependencies from a GitHub repo, as suggested by the feedback from -ports@
I would like to look into the wider issue of resolving/fetching dependencies for Maven based ports, but is easier to try that with a smaller and simpler project first, rather than Mesos which is quite complex.

Committed in r537999

Builds in {11.3,12.1}{amd64,i386} and 13-current amd64

Thanks for the submission, I'll commit shortly (with a small tweak to the lua bits).

This is last changes for this port, but i wrote to bugzilla next comment

I updated file with diff

Looks like this was done as part of rP500731, perhaps we can close?

Committed: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241605#c3

Removed PORTREVISION bump from devel/geany/Makefile, and improved dependency check to test for a spefic colour theme file as suggested.

I forgot, there is also no need to bump geany PORTREVISION, since you're only adding a non default option. No need to force rebuilding the package/reinstalling.

Thanks for the patch. I'll commit it later, only changing the RUN_DEPENDS line.

Changed devel/geany/Makefile to remove THEMES option from default options.

In D22378#492040, @james.wright_digital-chaos.com wrote:

I don't much like having to add a slave port, so inverting the dependency sounds like best option.

I don't much like having to add a slave port, so inverting the dependency sounds like best option.