Page MenuHomeFreeBSD

audio/spotify-player: Fast, easy to use, and configurable terminal music player.
ClosedPublic

Authored by jfree on Sep 21 2022, 4:18 AM.
Referenced Files
Unknown Object (File)
Fri, Nov 8, 5:53 PM
Unknown Object (File)
Tue, Nov 5, 11:28 AM
Unknown Object (File)
Tue, Nov 5, 9:09 AM
Unknown Object (File)
Sat, Nov 2, 8:11 PM
Unknown Object (File)
Thu, Oct 17, 2:02 AM
Unknown Object (File)
Oct 16 2024, 12:56 AM
Unknown Object (File)
Oct 15 2024, 4:12 PM
Unknown Object (File)
Oct 14 2024, 5:17 PM
Subscribers
None

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jfree requested review of this revision.Sep 21 2022, 4:18 AM
jfree created this revision.

Looks great other than these little nit-picks. An entry in audio/Makefile is also required.

I'm doing a build/run test, but that will take a few hours.

audio/spotify-player/Makefile
8

Command driven spotify player

Section 5.6 of the Porter's Handbook says,

Do not start with an indefinite article (that is, A or An).

audio/spotify-player/pkg-descr
6

You probably want to wrap this line so that it doesn't exceed 80 characters.

Features:
- Minimalist UI with an intuitive paging and popup system.
- Highly configurable, allow to easily customize application's shortcuts or
  theme/color scheme.
- Feature parity with the official Spotify application.
- Support remote control with Spotify Connect.
- Support streaming songs directly from the terminal.
- Support lyric for most songs.
- Support cross-platform media control.
- Support image rendering.

Joe, thank you for taking a look at this. I will fix up those issues by the end of the day.

In D36645#832055, @jrm wrote:

I'm doing a build/run test, but that will take a few hours

During my testing of this port, I found that poudriere-devel has a testport -b [branch] flag that
prefetches most dependencies as packages through the pkg repos.

This was especially useful for this port because Rust takes ~1-2 hours to build on my
machine. Perhaps you already know about this flag, but I thought I would bring it up
because it made my life a lot easier.

During my testing of this port, I found that poudriere-devel has a testport -b [branch] flag that
prefetches most dependencies as packages through the pkg repos.

This was especially useful for this port because Rust takes ~1-2 hours to build on my
machine. Perhaps you already know about this flag, but I thought I would bring it up
because it made my life a lot easier.

The official repositories can lag a bit behind the ports tree, so you may not be testing with the latest dependencies. That said, I've been testing with custom repositories for years. The official package builders are probably much faster, so I'll have to reevaluate my workflow.

  • Added "spotify-player" to audio/Makefile
  • Removed "A" from start of COMMENT
  • Updated pkg-descr to wrap lines after 80 characters

Full build tests and run-time tests look good here. Thanks. I'll commit.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 21 2022, 8:33 PM
This revision was automatically updated to reflect the committed changes.