Details
- Reviewers
jrm - Commits
- R11:db8cdd73dcac: audio/spotify-player: [New port] Terminal music player
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Looks great other than these little nit-picks. An entry in audio/Makefile is also required.
I'm doing a build/run test, but that will take a few hours.
audio/spotify-player/Makefile | ||
---|---|---|
8 | Command driven spotify player Section 5.6 of the Porter's Handbook says,
| |
audio/spotify-player/pkg-descr | ||
6 | You probably want to wrap this line so that it doesn't exceed 80 characters. Features: - Minimalist UI with an intuitive paging and popup system. - Highly configurable, allow to easily customize application's shortcuts or theme/color scheme. - Feature parity with the official Spotify application. - Support remote control with Spotify Connect. - Support streaming songs directly from the terminal. - Support lyric for most songs. - Support cross-platform media control. - Support image rendering. |
Joe, thank you for taking a look at this. I will fix up those issues by the end of the day.
During my testing of this port, I found that poudriere-devel has a testport -b [branch] flag that
prefetches most dependencies as packages through the pkg repos.
This was especially useful for this port because Rust takes ~1-2 hours to build on my
machine. Perhaps you already know about this flag, but I thought I would bring it up
because it made my life a lot easier.
The official repositories can lag a bit behind the ports tree, so you may not be testing with the latest dependencies. That said, I've been testing with custom repositories for years. The official package builders are probably much faster, so I'll have to reevaluate my workflow.
- Added "spotify-player" to audio/Makefile
- Removed "A" from start of COMMENT
- Updated pkg-descr to wrap lines after 80 characters