Good by me - I did add this for extra safety because the malloc markers are checked on free. And since we havent been bitten yet, I guess we are good:)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Nov 22 2018
Nov 22 2018
Nov 16 2018
Nov 16 2018
In D17947#384896, @bcran wrote:In D17947#384893, @allanjude wrote:I think the EFI size should be 200MB or 256MB, rather than 35MB
I’m not sure that the install media should waste that much space for the ESP. It should definitely be around 200MB when being installed though.
Nov 7 2018
Nov 7 2018
loader: ptable_open() check for ptable_cd9660read result is wrong
tsoome added a comment to D17890: loader: ptable_open() check for ptable_cd9660read result is wrong.
In D17890#382275, @lev wrote:This helps. It doen't show BSD partitions, but shows all four MBR slices without crash.
loader: always set media size from partition.
Nov 5 2018
Nov 5 2018
Typo fixed.
Nov 3 2018
Nov 3 2018
Nov 2 2018
Nov 2 2018
loader: biosdisk should check if the media is present
loader: do not probe floppy devices for zfs
Nov 1 2018
Nov 1 2018
libsa: cstyle cleanup tftp.c
libsa: tftp should use calloc
libsa: tftp should not read past file end
Oct 31 2018
Oct 31 2018
loader: issue edd probe before legacy ah=08 and detect no media
tsoome added inline comments to D17667: loader: issue edd probe before legacy ah=08 and detect no media.
tsoome updated the diff for D17667: loader: issue edd probe before legacy ah=08 and detect no media.
Test the presence of floppy device before attempting to read information
about it. We can get bogus information about non-existing floppy devices.
Oct 23 2018
Oct 23 2018
loader: biosdisk interface should be able to cope with 4k sectors
libsa: re-send ACK for older data packets in tftp
tsoome added inline comments to D11174: loader: biosdisk interface should be able to cope with 4k sectors.
Oct 22 2018
Oct 22 2018
tsoome updated the diff for D11174: loader: biosdisk interface should be able to cope with 4k sectors.
add sector size checks.
Oct 12 2018
Oct 12 2018
loader.efi: add poweroff command
Oct 10 2018
Oct 10 2018
Sep 12 2018
Sep 12 2018
In D17131#365407, @imp wrote:Generally I like this, but it also looks like there's some drive reset retry logic tossed in as well...
tsoome added a reviewer for D17131: loader: create bio_alloc and bio_free for bios bounce buffer: cperciva.
BIO_BUFFER_SIZE is defined in libi386.h
Sep 9 2018
Sep 9 2018
libsa: validate tftp_makereq() after we did reset the read
Sep 8 2018
Sep 8 2018
libsa: memory leak in tftp_open()
Sep 6 2018
Sep 6 2018
Sep 2 2018
Sep 2 2018
Aug 22 2018
Aug 22 2018
loader: bios loader should allow to chain load a file
Aug 19 2018
Aug 19 2018
tsoome added inline comments to D11174: loader: biosdisk interface should be able to cope with 4k sectors.
Aug 16 2018
Aug 16 2018
tsoome added inline comments to D11174: loader: biosdisk interface should be able to cope with 4k sectors.
tsoome updated the diff for D11174: loader: biosdisk interface should be able to cope with 4k sectors.
reverted comment, requested by imp.
tsoome added a comment to D11174: loader: biosdisk interface should be able to cope with 4k sectors.
Comments updated.
tsoome updated the summary of D11174: loader: biosdisk interface should be able to cope with 4k sectors.
tsoome updated the diff for D11174: loader: biosdisk interface should be able to cope with 4k sectors.
Rebase on recent rev.
libi386: bd_io_workaround() is to be called for reads only
libi386: small style updates in biosdisk
Aug 15 2018
Aug 15 2018
libi386: use BD_RD and BR_WR constants
libi386: remove bd_read() and bd_write() wrappers
libsa: zfs_probe() needs to set spa to NULL
libi386: remove BD_SUPPORT_FRAGS
cd9660 pointer sign issues and missing __packed attribute
Aug 7 2018
Aug 7 2018
libsa: gzipfs.c converts pointers to integer types with different sign
libsa: dos_checksum() should take unsigned chars
Aug 6 2018
Aug 6 2018
Aug 5 2018
Aug 5 2018
loader: bd_open() should cleanup from disk_open() error
loader: 337353 did miss to rename 2 write instances
loader: cstyle cleanup for biosdisk.c
Aug 4 2018
Aug 4 2018
loader: biosdisk.c has leftover geli header.
Aug 3 2018
Aug 3 2018
loader.efi: clean up misleading noise from missing block devices
Aug 2 2018
Aug 2 2018
loader.efi: efipart_inithandles() failure should not prevent devsw…
libsa: dereferencing type-punned pointer in cd9660
Aug 1 2018
Aug 1 2018
libsa: assignment to char * from u_char *
libsa: bootp is using pointers with different sign
libsa: pointer differs in signedness
Jul 23 2018
Jul 23 2018
Seems OK
Jul 19 2018
Jul 19 2018
In D16322#346807, @ish_amail.plala.or.jp wrote:Sorry, although this patch is good working from rEFInd, it is not working for loader prompt.
While showing boot menu, press '3' and go to loader prompt.
OK set rootdev=disk0pX
OK boot
The OS is booted from currdev, not from rootdev.
Jul 18 2018
Jul 18 2018
In D12698#346268, @eric_metricspace.net wrote:Some part of this ought to be committed, as it enables TPM support in EFI. It's worth discussing exactly which parts are necessary.
Jul 17 2018
Jul 17 2018
Jul 16 2018
Jul 16 2018
Jul 14 2018
Jul 14 2018
regex/engine.c: error: variable 'dp' set but not used
Jun 30 2018
Jun 30 2018
Jun 16 2018
Jun 16 2018
Jun 15 2018
Jun 15 2018
In D15207#334555, @imp wrote:I don't like this change at all. There's no practical difference, and this diverges us from the normal unix APIs.
gptboot.c was missing the switch to uint64_t
Jun 14 2018
Jun 14 2018
libsa: open() should use NULL instead of typecasted 0
libsa: remobe unneeded check before free()
libsa: f_rabuf could be NULL
libsa: cstyle cleanup for open/close/read/write sources
Jun 13 2018
Jun 13 2018
Jun 8 2018
Jun 8 2018
In D12732#331837, @eric_metricspace.net wrote:Rebase from master and tried on real hardware
May 28 2018
May 28 2018
May 3 2018
May 3 2018
In D15207#322069, @avg wrote:In D15207#322067, @tsoome wrote:In D15207#322036, @avg wrote:I think that on FreeBSD off_t is always 64 bit.
Yes, thats correct, it is 8 bytes (did verify). However, there is still issue of sign. Of course even with signed case we have quite a large max value there...
I think that the difference between 2⁶⁴ and 2⁶³ is negligible for all practical purposes.