Page MenuHomeFreeBSD

cd9660 pointer sign issues and missing __packed attribute
ClosedPublic

Authored by tsoome on Aug 2 2018, 10:16 AM.
Tags
None
Referenced Files
F151182504: D16564.id46689.diff
Mon, Apr 6, 3:57 PM
Unknown Object (File)
Mon, Apr 6, 5:55 AM
Unknown Object (File)
Sun, Mar 22, 12:36 AM
Unknown Object (File)
Thu, Mar 19, 11:18 AM
Unknown Object (File)
Mar 7 2026, 2:21 PM
Unknown Object (File)
Feb 25 2026, 12:03 AM
Unknown Object (File)
Feb 17 2026, 8:04 AM
Unknown Object (File)
Feb 16 2026, 1:19 AM
Subscribers

Details

Summary

the isonum_* functions are defined to take unsigend char* as an argument,
but the structure fields are defined as char. Change to u_char where needed.

Probably the full structure should be changed, but I'm not sure about the
side affects.

while there, add __packed attribute.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2018, 6:42 AM
This revision was automatically updated to reflect the committed changes.