cd9660 pointer sign issues and missing __packed attribute
ClosedPublic
Actions

Authored by tsoome on Aug 2 2018, 10:16 AM.

Tags

None

Referenced Files

	F167696889: D16564.id46177.diff
	Sun, Aug 23, 8:22 PM

	Unknown Object (File)
	Sat, Aug 22, 5:55 PM

	Unknown Object (File)
	Sat, Aug 22, 9:36 AM

	Unknown Object (File)
	Wed, Aug 19, 4:55 PM

	Unknown Object (File)
	Tue, Aug 18, 9:27 PM

	Unknown Object (File)
	Tue, Aug 18, 8:29 PM

	Unknown Object (File)
	Tue, Aug 18, 8:05 PM

	Unknown Object (File)
	Tue, Aug 18, 6:22 PM

View All Files

Subscribers

imp

Details

Reviewers: None
Commits: rS337833: cd9660 pointer sign issues and missing __packed attribute

Summary

the isonum_* functions are defined to take unsigend char* as an argument,
but the structure fields are defined as char. Change to u_char where needed.

Probably the full structure should be changed, but I'm not sure about the
side affects.

while there, add __packed attribute.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Aug 2 2018, 10:16 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 2 2018, 10:16 AM

Harbormaster completed remote builds in B18517: Diff 46177.Aug 2 2018, 10:16 AM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2018, 6:42 AM

Closed by commit rS337833: cd9660 pointer sign issues and missing __packed attribute (authored by tsoome). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

fs/

cd9660/

cd9660_rrip.h

6 lines

iso.h

28 lines

Diff 46689

View Options

head/sys/fs/cd9660/cd9660_rrip.h