Page MenuHomeFreeBSD

cd9660 pointer sign issues and missing __packed attribute
ClosedPublic

Authored by tsoome on Aug 2 2018, 10:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 22, 7:49 PM
Unknown Object (File)
Wed, Oct 22, 7:47 PM
Unknown Object (File)
Wed, Oct 22, 7:47 PM
Unknown Object (File)
Wed, Oct 22, 9:18 AM
Unknown Object (File)
Sep 3 2025, 10:45 AM
Unknown Object (File)
Jul 8 2025, 2:36 PM
Unknown Object (File)
Jun 23 2025, 11:44 PM
Unknown Object (File)
Jun 19 2025, 10:35 AM
Subscribers

Details

Summary

the isonum_* functions are defined to take unsigend char* as an argument,
but the structure fields are defined as char. Change to u_char where needed.

Probably the full structure should be changed, but I'm not sure about the
side affects.

while there, add __packed attribute.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2018, 6:42 AM
This revision was automatically updated to reflect the committed changes.