Page MenuHomeFreeBSD

cd9660 pointer sign issues and missing __packed attribute
ClosedPublic

Authored by tsoome on Aug 2 2018, 10:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 27 2026, 5:11 AM
Unknown Object (File)
Apr 17 2026, 10:17 AM
Unknown Object (File)
Apr 16 2026, 9:18 AM
Unknown Object (File)
Apr 15 2026, 12:06 PM
Unknown Object (File)
Apr 12 2026, 1:29 PM
Unknown Object (File)
Apr 9 2026, 10:43 PM
Unknown Object (File)
Apr 6 2026, 3:57 PM
Unknown Object (File)
Apr 6 2026, 5:55 AM
Subscribers

Details

Summary

the isonum_* functions are defined to take unsigend char* as an argument,
but the structure fields are defined as char. Change to u_char where needed.

Probably the full structure should be changed, but I'm not sure about the
side affects.

while there, add __packed attribute.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2018, 6:42 AM
This revision was automatically updated to reflect the committed changes.