Page MenuHomeFreeBSD

cd9660 pointer sign issues and missing __packed attribute
ClosedPublic

Authored by tsoome on Aug 2 2018, 10:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 7:15 PM
Unknown Object (File)
Wed, Jan 29, 7:58 AM
Unknown Object (File)
Sat, Jan 18, 8:32 AM
Unknown Object (File)
Sat, Jan 18, 8:30 AM
Unknown Object (File)
Oct 8 2024, 4:55 PM
Unknown Object (File)
Sep 29 2024, 6:33 PM
Unknown Object (File)
Sep 29 2024, 6:33 PM
Unknown Object (File)
Sep 29 2024, 4:35 PM
Subscribers

Details

Summary

the isonum_* functions are defined to take unsigend char* as an argument,
but the structure fields are defined as char. Change to u_char where needed.

Probably the full structure should be changed, but I'm not sure about the
side affects.

while there, add __packed attribute.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2018, 6:42 AM
This revision was automatically updated to reflect the committed changes.