Page MenuHomeFreeBSD

cd9660 pointer sign issues and missing __packed attribute
ClosedPublic

Authored by tsoome on Aug 2 2018, 10:16 AM.
Tags
None
Referenced Files
F84799578: D16564.diff
Tue, May 28, 7:18 PM
Unknown Object (File)
Wed, May 22, 2:10 AM
Unknown Object (File)
Tue, May 21, 8:48 AM
Unknown Object (File)
Tue, May 21, 4:11 AM
Unknown Object (File)
Sat, May 18, 9:28 AM
Unknown Object (File)
Sat, May 4, 2:25 AM
Unknown Object (File)
Tue, Apr 30, 11:43 AM
Unknown Object (File)
Tue, Apr 30, 9:14 AM
Subscribers

Details

Summary

the isonum_* functions are defined to take unsigend char* as an argument,
but the structure fields are defined as char. Change to u_char where needed.

Probably the full structure should be changed, but I'm not sure about the
side affects.

while there, add __packed attribute.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18517
Build 18222: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2018, 6:42 AM
This revision was automatically updated to reflect the committed changes.