libsa: validate tftp_makereq() after we did reset the read
ClosedPublic
Actions

Authored by tsoome on Sep 8 2018, 7:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 10, 8:11 PM

	Unknown Object (File)
	Fri, Sep 4, 1:18 PM

	Unknown Object (File)
	Tue, Sep 1, 11:43 PM

	Unknown Object (File)
	Sun, Aug 30, 4:57 AM

	Unknown Object (File)
	Fri, Aug 28, 8:24 PM

	Unknown Object (File)
	Wed, Aug 26, 11:35 PM

	Unknown Object (File)
	Fri, Aug 21, 10:53 PM

	Unknown Object (File)
	Aug 18 2026, 2:26 AM

View All Files

Subscribers

imp

Details

Reviewers

allanjude

Commits

rS338540: libsa: validate tftp_makereq() after we did reset the read

Summary

The name check referred in the comment is not the only possible error source,
we need to validate the result.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Sep 8 2018, 7:29 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 8 2018, 7:29 PM

Harbormaster completed remote builds in B19465: Diff 47819.Sep 8 2018, 7:29 PM

allanjude accepted this revision.Sep 8 2018, 7:31 PM

This revision is now accepted and ready to land.Sep 8 2018, 7:31 PM

Closed by commit rS338540: libsa: validate tftp_makereq() after we did reset the read (authored by tsoome). · Explain WhySep 9 2018, 6:30 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

libsa/

tftp.c

17 lines

Diff 47828

View Options

libsa: validate tftp_makereq() after we did reset the readClosedPublicActions