Differential D17087

libsa: re-send ACK for older data packets
ClosedPublic
Actions

Authored by tsoome on Sep 9 2018, 7:07 AM.

Tags

None

Referenced Files

	F103199220: D17087.id49503.diff
	Fri, Nov 22, 4:18 AM

	Unknown Object (File)
	Oct 12 2024, 8:58 PM

	Unknown Object (File)
	Sep 18 2024, 9:09 AM

	Unknown Object (File)
	Sep 8 2024, 1:15 PM

	Unknown Object (File)
	Sep 7 2024, 9:42 PM

	Unknown Object (File)
	Sep 7 2024, 7:56 AM

	Unknown Object (File)
	Sep 5 2024, 5:13 AM

	Unknown Object (File)
	Aug 12 2024, 8:27 AM

View All 40 Files

Subscribers

Details

Reviewers: None
Commits: rS339651: libsa: re-send ACK for older data packets in tftp

Summary

In current code we drop out-of-order packets; however, we should play nice and re-send ACK for older data packets we are receiving. This will hopefully stop server repeating those packets we already have received. Note we do not answer duplicates from "previous" session (that is, session with different port number), those will eventually time out.

Porting: https://www.illumos.org/rb/r/1198/

Test Plan

Tested with physical systems where the issue was initially found and also I did manage to get duplicates using VPN link over slow wifi.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Sep 9 2018, 7:07 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 9 2018, 7:07 AM

Harbormaster completed remote builds in B19471: Diff 47829.Sep 9 2018, 7:07 AM

tsoome edited the summary of this revision. (Show Details)Oct 10 2018, 10:01 AM

tsoome edited the test plan for this revision. (Show Details)

This revision was not accepted when it landed; it landed in state Needs Review.Oct 23 2018, 1:38 PM

Closed by commit rS339651: libsa: re-send ACK for older data packets in tftp (authored by tsoome). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

libsa/

18 lines

Diff 49503

head/stand/libsa/tftp.c

Loading...