Page MenuHomeFreeBSD

Sanity check BIOS EDD CHS numbers before using them.
ClosedPublic

Authored by delphij on Aug 4 2018, 8:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 3, 4:40 AM
Unknown Object (File)
Wed, May 14, 6:24 AM
Unknown Object (File)
Apr 15 2025, 3:38 PM
Unknown Object (File)
Apr 14 2025, 11:12 AM
Unknown Object (File)
Apr 11 2025, 2:22 AM
Unknown Object (File)
Mar 22 2025, 1:34 AM
Unknown Object (File)
Mar 20 2025, 7:29 PM
Unknown Object (File)
Mar 13 2025, 12:55 PM
Subscribers

Details

Reviewers
cy
tsoome
Summary

In r337271, we limited the sector number to the lower of calculated
number and CHS based number. However, on some systems, BIOS would
report 0 in CHS fields, making the system to think there is 0 sectors.

Add a check before comparing the calculated total with bd_sectors.

Test Plan

boot

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18577
Build 18272: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 4 2018, 11:12 AM

The above change allowed a kernel to load on my laptop[[ https://wiki.freebsd.org/Laptops/Dell_Precision_M4800?highlight=(\bCategoryLaptop\b)| Dell Precision M4800 ]] after updating from r337232 -> r337285; without the change, the kernel was unloadable ("Can't load kernel") and I didn't even get a loader menu (e.g., to facilitate loading a different kernel).

Referenced wrong review. This was committed as rS337317.