Page MenuHomeFreeBSD

Get rid of superfluous "bug marker" code in the bcache

Authored by sobomax on Nov 22 2018, 6:16 PM.



Read-ahead code introduced in the r313332 contains "the end of cache marker" which I believe superfluous, as cache is allocated on heap and there is already a similar code in the malloc()/free() to detect data corruption and panic:

$ grep USEENDGUARD /usr/src/stand/libsa/*.[ch]
/usr/src/stand/libsa/zalloc_defs.h:#define USEENDGUARD
/usr/src/stand/libsa/zalloc_malloc.c:#ifdef USEENDGUARD
/usr/src/stand/libsa/zalloc_malloc.c:#ifdef USEENDGUARD
/usr/src/stand/libsa/zalloc_malloc.c:#ifdef USEENDGUARD

I believe that code is more "correct" since such incidents should not be taken lightly as often loader logs are not easily available and or often looked upon. Merely issuing a warning when condition is detected is not sufficient since allowing system to continue bootstrap is likely to cause a subsequent kernel crash/misbehaviour that would be really hard to debug and can lead to a severe data corruption as well.

Diff Detail

rS FreeBSD src repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sobomax created this revision.Nov 22 2018, 6:16 PM
sobomax edited the summary of this revision. (Show Details)Nov 22 2018, 6:18 PM
tsoome accepted this revision.Nov 22 2018, 6:22 PM

Good by me - I did add this for extra safety because the malloc markers are checked on free. And since we havent been bitten yet, I guess we are good:)

This revision is now accepted and ready to land.Nov 22 2018, 6:22 PM
sobomax edited the summary of this revision. (Show Details)Nov 22 2018, 6:22 PM
This revision was automatically updated to reflect the committed changes.