Page MenuHomeFreeBSD
Differential D17822

loader: always set media size from partition.
ClosedPublic
Actions

Authored by tsoome on Nov 3 2018, 12:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 3, 9:55 AM
Unknown Object (File)
Tue, Dec 3, 9:55 AM
Unknown Object (File)
Tue, Dec 3, 9:55 AM
Unknown Object (File)
Tue, Dec 3, 9:54 AM
Unknown Object (File)
Tue, Dec 3, 9:43 AM
Unknown Object (File)
Tue, Nov 26, 10:06 PM
Unknown Object (File)
Sun, Nov 24, 3:29 PM
Unknown Object (File)
Nov 22 2024, 12:11 PM
View All 62 Files
Subscribers
imp
juan.molina_club.fr

Details

Reviewers
None
Commits
rS341226: MFC r340215:
rS340215: loader: always set media size from partition.
Summary

The disk access is validated by using partition table definitions, therefore
we have no need for if statements, just set the disk size.

Of course the partition table itself may be incorrect/inconsistent, but if
so, we are in trouble anyhow.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tsoome created this revision.Nov 3 2018, 12:52 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 3 2018, 12:52 PM
Harbormaster completed remote builds in B20606: Diff 49967.Nov 3 2018, 12:52 PM
imp added a comment.Nov 4 2018, 6:23 PM

Seems legit to me. I like the abstraction even if we don't determine the size in multiple places.

juan.molina_club.fr added a subscriber: juan.molina_club.fr.Nov 5 2018, 8:59 AM
juan.molina_club.fr added inline comments.
stand/i386/libi386/biosdisk.c
445 ↗(On Diff #49967)

Typo: mulitplication

tsoome marked 2 inline comments as done.Nov 5 2018, 9:00 AM
tsoome added inline comments.
stand/i386/libi386/biosdisk.c
445 ↗(On Diff #49967)

Yes, thanks:)

tsoome updated this revision to Diff 50022.Nov 5 2018, 9:01 AM
tsoome marked an inline comment as done.

Typo fixed.

Harbormaster completed remote builds in B20635: Diff 50022.Nov 5 2018, 9:01 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 7 2018, 11:14 AM
Closed by commit rS340215: loader: always set media size from partition. (authored by tsoome). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
stand/
common/
4 lines
3 lines
i386/
libi386/
56 lines

Diff 50115

View Options

head/stand/common/disk.c

Loading...
View Options

head/stand/common/part.c

Loading...
View Options

head/stand/i386/libi386/biosdisk.c

Loading...