linux(4): Get rid of Linuxulator's kernel build options.
ClosedPublic
Actions

Authored by dchagin on Jun 13 2021, 2:28 PM.

Details

Reviewers

Group Reviewers

manpages
Linux Emulation

Commits

rG5833253dad65: linux(4): Get rid of Linuxulator kernel build options.
rGe013e36939ac: linux(4): Get rid of Linuxulator kernel build options.

Summary

Stop confusing people and retire COMPAT_LINUX and COMPAT_LINUX32 kernel
build options. Since we have 64-bit Linux emulation we can't build both
emulators into the kernel. And I don't think it matters, Linux emulation
depends on loadable modules (via rc).

Cut LINPROCFS and LINSYSFS for consistency.

I haven't removed opt_compat.h, maybe we should as there no any COMPAT
option left.

PR: 215061
MFC after: 2 weeks

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39902
Build 36791: arc lint + arc unit

Event Timeline

dchagin created this revision.Jun 13 2021, 2:28 PM

Herald added a reviewer: manpages. · View Herald TranscriptJun 13 2021, 2:28 PM

Herald added a subscriber: imp. · View Herald Transcript

dchagin requested review of this revision.Jun 13 2021, 2:28 PM

Harbormaster completed remote builds in B39874: Diff 90812.Jun 13 2021, 2:28 PM

dchagin added a reviewer: Linux Emulation.Jun 13 2021, 2:29 PM

dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

To make sure I understand this: this change is to no longer allow Linuxulator to be built into the kernel, and only allow it to be built as a module?

share/man/man4/tdfx.4
52–56	By loading the
56	modules, you can enable the linux ioctl code for this driver, where the only supported
sys/amd64/conf/NOTES
263–264	"both" what? I think you mean # To enable Linuxulator support, one must also load linux.ko and tdfx_linux.ko Is that correct?
sys/i386/conf/NOTES
432	# To enable Linuxulator support, load tdfx and tdfx_linux as modules. The i386 and amd64 versions of this comment should match; I think this version is clearer.

fixed Ravi's comments. thanks!

Harbormaster completed remote builds in B39902: Diff 90861.Jun 14 2021, 6:15 AM

In D30751#691414, @rpokala wrote:

To make sure I understand this: this change is to no longer allow Linuxulator to be built into the kernel, and only allow it to be built as a module?

yes, you are right