Page MenuHomeFreeBSD
Differential D58705

net80211: add key get/set methods
ClosedPublic
Actions

Authored by adrian on Fri, Aug 7, 5:47 PM.
Tags
Referenced Files
F167274474: D58705.diff
Thu, Aug 20, 2:08 PM
Unknown Object (File)
Wed, Aug 19, 3:16 PM
Unknown Object (File)
Wed, Aug 19, 3:11 PM
Unknown Object (File)
Wed, Aug 19, 3:10 PM
Unknown Object (File)
Wed, Aug 19, 2:23 PM
Unknown Object (File)
Tue, Aug 18, 8:32 PM
Unknown Object (File)
Tue, Aug 18, 5:05 PM
Unknown Object (File)
Mon, Aug 17, 6:45 PM
View All 28 Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rGdb4d6f76407c: net80211: add key get/set methods
Summary

Introduce net80211 key get and set methods with appropriate
bounds checking and buffer zero'ing.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75616
Build 72499: arc lint + arc unit

Event Timeline

adrian created this revision.Fri, Aug 7, 5:47 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptFri, Aug 7, 5:47 PM
adrian requested review of this revision.Fri, Aug 7, 5:47 PM
Harbormaster completed remote builds in B75435: Diff 183631.Fri, Aug 7, 5:47 PM
adrian added a child revision: D58384: net80211: migrate the ioctl API to a 128 bit specific API + use key API.Fri, Aug 7, 6:52 PM
adrian added a parent revision: D57312: net80211: delete the deprecated ieee80211_wepkey struct.
adrian added reviewers: wireless, bz.
adrian added a project: wireless.
adrian updated this revision to Diff 183703.Sun, Aug 9, 1:47 AM

update

Harbormaster completed remote builds in B75468: Diff 183703.Sun, Aug 9, 1:47 AM
adrian added a comment.Sun, Aug 9, 2:12 AM

@bz ok this should implement the behaviours you wanted - bounds checking, buffer zero'ing, etc. Please let me know.

adrian added a child revision: D58854: net80211: fix WEP transmit.Sat, Aug 15, 2:42 AM
adrian removed a child revision: D58384: net80211: migrate the ioctl API to a 128 bit specific API + use key API.
adrian updated this revision to Diff 184118.Sun, Aug 16, 12:30 AM

fix; 0 size keys returning 0 == false which leads to APIs returning EINVAL

Harbormaster completed remote builds in B75616: Diff 184118.Sun, Aug 16, 12:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Aug 19, 2:07 AM
Closed by commit rGdb4d6f76407c: net80211: add key get/set methods (authored by adrian). · Explain Why
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rGdb4d6f76407c: net80211: add key get/set methods.

Revision Contents
Changeset List

PathSize
sys/
net80211/
147 lines

Diff 184118

View Options

sys/net80211/ieee80211_crypto.h

Loading...