Page MenuHomeFreeBSD
Differential D53343

ipfw: Retire obsolete compat code
ClosedPublic
Actions

Authored by emaste on Oct 24 2025, 8:33 PM.
Tags
None
Referenced Files
F163130251: D53343.id165009.diff
Mon, Jul 20, 8:43 AM
F163040841: D53343.id165163.diff
Sun, Jul 19, 12:52 PM
Unknown Object (File)
Sun, Jul 19, 3:16 AM
Unknown Object (File)
Sat, Jul 18, 10:14 AM
Unknown Object (File)
Fri, Jul 17, 10:25 PM
Unknown Object (File)
Wed, Jul 15, 6:51 AM
Unknown Object (File)
Wed, Jul 15, 6:51 AM
Unknown Object (File)
Thu, Jun 25, 6:34 AM
View All 68 Files
Subscribers
donner
glebius
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
markj
ae
glebius
Commits
rG57865e505aef: ipfw: Retire obsolete compat code
rG660255be1ed9: ipfw: Retire obsolete compat code
rG9657c50cdd77: ipfw: Retire obsolete compat code
rGc59aab9a5b39: ipfw: Retire obsolete compat code
Summary
The current IPFW version dates to 2010 (commit cc4d3c30ea28, "Bring in
the most recent version of ipfw and dummynet, developed").  We no longer
need backwards compatibility with FreeBSD 8 and earlier.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Oct 24 2025, 8:33 PM
Herald added subscribers: vegeta_tuxpowered.net, glebius, donner, melifaro. · View Herald TranscriptOct 24 2025, 8:33 PM
emaste requested review of this revision.Oct 24 2025, 8:33 PM
emaste added a parent revision: D53341: ipfw: Update warning/error setsockopt references.
markj added a comment.Oct 24 2025, 8:37 PM

There's a reference to IP_DUMMYNET_GET in sbin/ipfw/ipfw2.c that can probably be removed as well.

emaste added a comment.Oct 24 2025, 8:53 PM
In D53343#1218208, @markj wrote:

There's a reference to IP_DUMMYNET_GET in sbin/ipfw/ipfw2.c that can probably be removed as well.

Fair point, D53348

emaste added a parent revision: D53348: ipfw: Remove IP_DUMMYNET_GET case.Oct 24 2025, 8:57 PM
ae accepted this revision.Oct 25 2025, 7:01 PM

LGTM.

This revision is now accepted and ready to land.Oct 25 2025, 7:01 PM
glebius accepted this revision.Oct 26 2025, 4:51 AM
glebius added inline comments.
sys/modules/dummynet/Makefile
2–3

Maybe merge those SRCS declarations? At least first two into one line.

emaste added a comment.Oct 27 2025, 2:25 PM

There's a reference to IP_DUMMYNET_GET in sbin/ipfw/ipfw2.c that can probably be removed as well.

Actually there's a bunch of unused cases in do_cmd() not just IP_DUMMYNET_GET -- D53378

Closed by commit rGc59aab9a5b39: ipfw: Retire obsolete compat code (authored by emaste). · Explain WhyOct 27 2025, 7:46 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGc59aab9a5b39: ipfw: Retire obsolete compat code.
Herald added a subscriber: imp. · View Herald TranscriptOct 27 2025, 7:46 PM
emaste added a commit: rG9657c50cdd77: ipfw: Retire obsolete compat code.Oct 30 2025, 8:07 PM
cperciva added a commit: rG660255be1ed9: ipfw: Retire obsolete compat code.Oct 30 2025, 8:54 PM
emaste added a commit: rG57865e505aef: ipfw: Retire obsolete compat code.Nov 20 2025, 3:39 PM

Revision Contents
Changeset List

PathSize
sys/
conf/
1 line
modules/
dummynet/
3 lines
netinet/
4 lines
netpfil/
ipfw/
10 lines
96 lines

Diff 165163

View Options

sys/conf/files

Loading...
View Options

sys/modules/dummynet/Makefile

Loading...
View Options

sys/netinet/raw_ip.c

Loading...
View Options

sys/netpfil/ipfw/ip_dn_glue.c

Loading...
View Options

sys/netpfil/ipfw/ip_dn_private.h

Loading...
View Options

sys/netpfil/ipfw/ip_dummynet.c

Loading...