Page MenuHomeFreeBSD
Differential D53378

ipfw: Remove more unused IP_FW_* cases
ClosedPublic
Actions

Authored by emaste on Oct 27 2025, 2:24 PM.
Tags
None
Referenced Files
F147644830: D53378.id.diff
Thu, Mar 12, 1:43 PM
F147610182: D53378.id.diff
Thu, Mar 12, 7:42 AM
Unknown Object (File)
Wed, Mar 11, 9:46 AM
Unknown Object (File)
Mon, Mar 2, 8:20 PM
Unknown Object (File)
Mon, Mar 2, 8:20 PM
Unknown Object (File)
Mon, Mar 2, 8:19 PM
Unknown Object (File)
Fri, Feb 27, 10:36 AM
Unknown Object (File)
Sat, Feb 21, 7:43 AM
View All 35 Files
Subscribers
donner
imp
markj

Details

Reviewers
markj
Commits
rG87b73c2684d5: ipfw: Remove more unused IP_FW_* cases
rG848075bff4de: ipfw: Remove more unused IP_FW_* cases
rG6b1e5d4d20a9: ipfw: Remove more unused IP_FW_* cases
rG0e2e0fb955ad: ipfw: Remove more unused IP_FW_* cases
Summary

These are not used in ipfw(8) so there's no need to handle them in do_cmd().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Oct 27 2025, 2:24 PM
Herald added a subscriber: donner. · View Herald TranscriptOct 27 2025, 2:24 PM
emaste requested review of this revision.Oct 27 2025, 2:24 PM
emaste mentioned this in D53343: ipfw: Retire obsolete compat code.
markj accepted this revision.Oct 27 2025, 3:18 PM
markj added a subscriber: markj.

All of the do_cmd() calls are in dummynet.c and specify the socket option at compile time.

This revision is now accepted and ready to land.Oct 27 2025, 3:18 PM
emaste added a comment.Oct 27 2025, 4:09 PM

All of the do_cmd() calls are in dummynet.c and specify the socket option at compile time.

Yeah, I'll make the commit message more explicit. These if cases are dead code.

Closed by commit rG0e2e0fb955ad: ipfw: Remove more unused IP_FW_* cases (authored by emaste). · Explain WhyOct 27 2025, 4:13 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG0e2e0fb955ad: ipfw: Remove more unused IP_FW_* cases.
Herald added a subscriber: imp. · View Herald TranscriptOct 27 2025, 4:13 PM
emaste added a commit: rG6b1e5d4d20a9: ipfw: Remove more unused IP_FW_* cases.Oct 29 2025, 1:41 PM
emaste added a commit: rG848075bff4de: ipfw: Remove more unused IP_FW_* cases.Oct 29 2025, 1:46 PM
cperciva added a commit: rG87b73c2684d5: ipfw: Remove more unused IP_FW_* cases.Oct 30 2025, 4:29 AM

Revision Contents
Changeset List

PathSize
sbin/
ipfw/
6 lines

Diff 165148

View Options

sbin/ipfw/ipfw2.c

Loading...