if_gif: Use the MTU on the gif interface for the outgoing packets
Needs RevisionPublic
Actions

Authored by meta on Sep 17 2025, 3:46 PM.

Details

Reviewers

zlei
ae
hrs
pouria

Group Reviewers

network

Summary

This is a revised version of D51866 to address review comments
and resolve conflicts after D51835.

As I mentioned in D51866 [1], I would like this changes to be included in
15.0-RELEASE. I worked on D51297 to ensure that the fix for bug 280736 would
be included in the release, as there has been no progress on D45854 for over
a year. Since this is a better approach for bug 280736, it should be included
as well.

Ongoing work can be seen on GitHub:
https://github.com/metalefty/freebsd-src/commits/gif/

[1] https://reviews.freebsd.org/D51866#1196328

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 67125
Build 64008: arc lint + arc unit

Event Timeline

meta created this revision.Sep 17 2025, 3:46 PM

Herald added subscribers: ivy, ziaee, glebius and 2 others. · View Herald TranscriptSep 17 2025, 3:46 PM

meta requested review of this revision.Sep 17 2025, 3:46 PM

Harbormaster completed remote builds in B67125: Diff 162268.Sep 17 2025, 3:46 PM

This worked very well for me, both for EtherIP (Ethernet-ovet-IPv6) and IPIP (v6-over-v6).

In D52594#1201880, @meta wrote:

This worked very well for me, both for EtherIP (Ethernet-ovet-IPv6) and IPIP (v6-over-v6).

I'm preparing the tests. It appears good.

I'm going to firstly integrate part of this change, to be precisely, the if_bridge's MTU change behavior of adding if_gif(4) as a member interface.

Please stop duplicating the existing review to obtain approval from someone else by excluding the original author.

This revision now requires changes to proceed.Sep 28 2025, 2:18 AM

Nothing had happened for over a year since D45854 was submitted. I just tried to get things moving to avoid waiting another year. Because we didn't get feedback from you after the reviewers left review comments, and the deadline was approaching.

To be clear, I did not intend to exclude you, just forgot to add.

pouria mentioned this in D51866: if_gif: Use the MTU on the gif interface for the outgoing packets.Feb 25 2026, 1:59 PM

@meta
IMHO, You may proceed again with 'Co-Authored-By: full name <email>' tag if and only if D51866 stalled again for another month.
I pinged the original revision to see if author is available to address @zlei and your comments or not.

In D52594#1270109, @pouria wrote:

@meta
IMHO, You may proceed again with 'Co-Authored-By: full name <email>' tag if and only if D51866 stalled again for another month.
I pinged the original revision to see if author is available to address @zlei and your comments or not.

I'd love to proceed. He tends to propose changes and respond to review comments a year or more later. Because of that, I could not manage to get this included in 15.0-RELEASE. It's been over a year since the original changes were proposed, so perhaps we should wait a shorter period.

Herald added a reviewer: pouria. · View Herald TranscriptMar 3 2026, 12:28 AM