net: use pfil_mbuf_{in,out} where we always have an mbuf
ClosedPublic
Actions

Authored by glebius on Jan 7 2023, 9:02 PM.

Details

Reviewers

mjg
kp

Group Reviewers

network

Commits

rGa22561501ff8: net: use pfil_mbuf_{in,out} where we always have an mbuf

Summary

This finalizes what has been started in 0b70e3e78b0.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Jan 7 2023, 9:02 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptJan 7 2023, 9:02 PM

glebius requested review of this revision.Jan 7 2023, 9:02 PM

Harbormaster completed remote builds in B48986: Diff 114829.Jan 7 2023, 9:02 PM

glebius added a child revision: D37977: pfil: add pfil_mem_{in,out}() and retire pfil_run_hooks().Jan 7 2023, 9:02 PM

mjg added inline comments.Jan 7 2023, 11:33 PM

sys/net/if_enc.c
310–314	what's up with yoda comparison?

kp added inline comments.Jan 8 2023, 7:15 AM

sys/net/if_enc.c

310–314

It could probably stand to be split out of the if() at least.

Maybe

ret = (pdir == PFIL_IN) ? pfil_mbuf_in(ph, ctx->mp, ifp, ctx->inp) :
	    pfil_mbuf_out(ph, ctx->mp, ifp, ctx->inp);
if (ret != PFIL_PASS)
...

Or even

if (pdir == PFIL_IN)
  ret = pfil_mbuf_in(ph, ctx->mp, ifp, ctx->inp) ;
else
  ret = pfil_mbuf_out(ph, ctx->mp, ifp, ctx->inp));
if (ret ![ PFIL_PASS) {
...

glebius added inline comments.Jan 9 2023, 5:25 PM

sys/net/if_enc.c
310–314	What I've written seems more readable to me. I'm open to using any other version. Kristof, Mateusz, just tell me a version you both agree with and I will use it :)