net: use pfil_mbuf_{in,out} where we always have an mbuf

[glebius]

Summary

This finalizes what has been started in 0b70e3e78b0.

[mjg]

sys/net/if_enc.c

310–314

what's up with yoda comparison?

[kp]

sys/net/if_enc.c

310–314

It could probably stand to be split out of the if() at least.

Maybe

ret = (pdir == PFIL_IN) ? pfil_mbuf_in(ph, ctx->mp, ifp, ctx->inp) :
	    pfil_mbuf_out(ph, ctx->mp, ifp, ctx->inp);
if (ret != PFIL_PASS)
...

Or even

if (pdir == PFIL_IN)
  ret = pfil_mbuf_in(ph, ctx->mp, ifp, ctx->inp) ;
else
  ret = pfil_mbuf_out(ph, ctx->mp, ifp, ctx->inp));
if (ret ![ PFIL_PASS) {
...

[glebius]

sys/net/if_enc.c

310–314

What I've written seems more readable to me. I'm open to using any other version. Kristof, Mateusz, just tell me a version you both agree with and I will use it :)

[mjg]

sys/net/if_enc.c

310–314

second variant looks good to me

[kp]

sys/net/if_enc.c

310–314

Works for me too.

[glebius]

Restyle if_enc as suggested