Page MenuHomeFreeBSD
Differential D34430

tslog.4: Document TSLOG
ClosedPublic
Actions

Authored by 0mp on Mar 3 2022, 9:25 PM.
Tags
None
Referenced Files
F109574190: D34430.diff
Thu, Feb 6, 10:04 PM
Unknown Object (File)
Mon, Jan 27, 11:59 AM
Unknown Object (File)
Sun, Jan 26, 10:12 PM
Unknown Object (File)
Wed, Jan 15, 8:49 AM
Unknown Object (File)
Sat, Jan 11, 6:43 AM
Unknown Object (File)
Sat, Jan 11, 4:55 AM
Unknown Object (File)
Dec 15 2024, 3:27 AM
Unknown Object (File)
Dec 15 2024, 1:43 AM
View All 67 Files
Subscribers
debdrup
imp

Details

Reviewers
cperciva
mhorne
manu
debdrup
Group Reviewers
manpages
Commits
rGb85d0d603c57: tslog.4: Document TSLOG
rG759880b587fa: tslog.4: Document TSLOG
rG5675bb582985: tslog.4: Document TSLOG
Summary

Based on commit messages and Colin Percival's presentation
from BSDCan 2018 [1].

[1]: https://papers.freebsd.org/2018/bsdcan/percival-Profiling_the_FreeBSD_kernel_boot.files/percival-Profiling_the_FreeBSD_kernel_boot.pdf

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44635
Build 41523: arc lint + arc unit

Event Timeline

0mp created this revision.Mar 3 2022, 9:25 PM
Herald added a reviewer: manpages. · View Herald TranscriptMar 3 2022, 9:25 PM
Herald added a subscriber: imp. · View Herald Transcript
0mp requested review of this revision.Mar 3 2022, 9:25 PM
Harbormaster completed remote builds in B44635: Diff 103459.Mar 3 2022, 9:25 PM
0mp added inline comments.Mar 3 2022, 9:27 PM
share/man/man4/tslog.4
96
  1. Let me know of you remember when TSLOG got introduced.
  2. This history section should probably be moved to a new manual page called tracing(7) or omitted.
cperciva added inline comments.Mar 3 2022, 9:49 PM
share/man/man4/tslog.4
46

"is able to trace the boot loader, kernel initialization, and userland processes"

75

s/kernel/loader and kernel/

96

December 31st, 2017 for the original kernel-only bits. Summer 2021 for the boot loader and userland bits.

0mp updated this revision to Diff 103460.Mar 3 2022, 9:59 PM
0mp marked 3 inline comments as done.
  • Address Colin's comments
  • Mention that TSLOG appeared in 12.0, and was extended in 14.0
Harbormaster completed remote builds in B44636: Diff 103460.Mar 3 2022, 10:00 PM
0mp added a comment.Mar 3 2022, 10:00 PM

Thanks, @cperciva!

debdrup accepted this revision.Mar 4 2022, 5:46 PM
debdrup added a subscriber: debdrup.

Manual page looks good to me.

This revision is now accepted and ready to land.Mar 4 2022, 5:46 PM
0mp added a comment.Mar 4 2022, 7:03 PM

Thanks, @debdrup!

I'll wait for a review from a src committer before I commit the patch.

cperciva accepted this revision.Mar 4 2022, 7:29 PM

Approved with src-committer hat.

Closed by commit rG5675bb582985: tslog.4: Document TSLOG (authored by 0mp). · Explain WhyMar 4 2022, 7:38 PM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rG5675bb582985: tslog.4: Document TSLOG.
0mp added a comment.Mar 4 2022, 7:39 PM

Thanks!

0mp added a commit: rG759880b587fa: tslog.4: Document TSLOG.Mar 11 2022, 10:05 AM
0mp added a commit: rGb85d0d603c57: tslog.4: Document TSLOG.Mar 11 2022, 10:09 AM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
1 line
128 lines

Diff 103459

View Options

share/man/man4/Makefile

Loading...
View Options

share/man/man4/tslog.4

Loading...